Skip to content

fix: include gRPC status code in batch delete error messages (Fixes #1030) #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtmalikian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: include gRPC status code in batch delete error messages (Fixes #1030) #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions weaviate/connect/v4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@ def grpc_batch_delete(
error = cast(Call, e)
if error.code() == StatusCode.PERMISSION_DENIED:
raise InsufficientPermissionsError(error)
raise WeaviateDeleteManyError(str(error.details()))
raise WeaviateDeleteManyError(f"[{error.code().name}] {error.details()}")

def grpc_tenants_get(
self, request: tenants_pb2.TenantsGetRequest
Expand Down Expand Up @@ -1232,7 +1232,7 @@ async def grpc_batch_delete(
except AioRpcError as e:
if e.code().name == PERMISSION_DENIED:
raise InsufficientPermissionsError(e)
raise WeaviateDeleteManyError(str(e))
raise WeaviateDeleteManyError(f"[{e.code().name}] {e.details()}")

async def grpc_batch_stream(
self,
Expand Down