Skip to content

chore(agent): remove node https module from web bundle#451

Merged
tsmith023 merged 5 commits into
feat/introduce-web-clientfrom
feat/introduce-web-client--remove-node-https-from-web
Jun 30, 2026
Merged

chore(agent): remove node https module from web bundle#451
tsmith023 merged 5 commits into
feat/introduce-web-clientfrom
feat/introduce-web-client--remove-node-https-from-web

Conversation

@iangregson

Copy link
Copy Markdown
Collaborator

Imports in core/src/connection were unintentionally bringing node's http/https module into the web bundle.
This change imports only the type in core/, imports the module in node/, and omits in web/ (which falls back to fetch).

@iangregson iangregson requested a review from tsmith023 June 29, 2026 15:43

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@iangregson

iangregson commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this hackday project out in favour of the work resumed on #307

@iangregson iangregson closed this Jun 30, 2026
@iangregson

Copy link
Copy Markdown
Collaborator Author

Closed the wrong PR 🤦

@iangregson iangregson reopened this Jun 30, 2026
@tsmith023 tsmith023 merged commit bb42b5e into feat/introduce-web-client Jun 30, 2026
13 checks passed
@tsmith023 tsmith023 deleted the feat/introduce-web-client--remove-node-https-from-web branch June 30, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants