fix: update Ruby, ActiveRecord matrix, and drop AR 6.x support#14
Open
scottybarr wants to merge 4 commits into
Open
fix: update Ruby, ActiveRecord matrix, and drop AR 6.x support#14scottybarr wants to merge 4 commits into
scottybarr wants to merge 4 commits into
Conversation
…ails deprecation API - Remove dead Rails 4.0.x shim that checked `MiniTest::Test`; modern minitest (5+) dropped the MiniTest constant in favour of Minitest, causing a NameError that prevented any test from loading - Guard `ActiveSupport::Deprecation` calls with respond_to? since Rails 7.1+ removed .behavior= and .silenced= from the singleton - Update actions/checkout from v4.3.1 to v6.0.2 and ruby/setup-ruby from v1.306.0 to v1.308.0 ahead of the June 2 2026 forced migration from Node.js 20 to 24 on GitHub Actions runners
minitest 6 (compatible with Ruby 3.4+) removed mock/stub support. Replace the Object#stub call with define_singleton_method, which is equivalent and has no framework dependency.
Both versions verified locally: 147 runs, 0 failures, 0 errors for each.
ActiveRecord 6.x is no longer included in the test matrix.
scottybarr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the broken CI on the
pin-actions/2026-04-29branch (and main, which has the same underlying issues) and bumps the gem to 3.2.0.Root causes fixed
NameError: uninitialized constant MiniTest— a Rails 4.0.x compatibility shim intest_helper.rbreferenced the oldMiniTestconstant, which was removed from modern minitest. This prevented any tests from loading at all.NoMethodError: undefined method 'behavior='—ActiveSupport::Deprecation.behavior=and.silenced=were removed in Rails 7.1+. Guarded both call sites withrespond_to?.NoMethodError: undefined method 'stub'— minitest 6 (which ships with Ruby 3.4+) removed mock/stub support entirely. Replaced withdefine_singleton_method.Other changes
.ruby-versionfrom 3.1.2 to 3.4.9actions/checkoutv4.3.1 → v6.0.2 andruby/setup-rubyv1.306.0 → v1.308.0 (Node.js 20 enforcement on GitHub Actions runners begins June 2, 2026)ActiveRecord 6.x support
ActiveRecord 6.x is no longer included in the test matrix and is not actively supported going forward. The gem code itself has not changed, so it may continue to work with AR 6.x, but this is not guaranteed or tested. This is reflected in the minor version bump to 3.2.0.
Test plan
ACTIVERECORD=7.2 bundle exec rake→ 147 runs, 0 failuresACTIVERECORD=8.1 bundle exec rake→ 147 runs, 0 failures