Error messaging + idling resource registration - #48
Merged
Merged
Conversation
… Also ensure the idling resource is un-registered in the event of an exception.
Kritarie
commented
Sep 15, 2026
Contributor
Author
There was a problem hiding this comment.
This more closely aligns with how we configure formatting rules in wf-android
https://www.jetbrains.com/help/idea/editorconfig.html
Without this my IDE was formatting with 4 spaces, which didn't align with the rest of the codebase
cmathew
reviewed
Sep 15, 2026
|
|
||
| try { | ||
| createDirectories(Path(screenshotDirectory)) | ||
| } catch (e: Exception) { |
Contributor
There was a problem hiding this comment.
which exceptions might the try block throw? Should we just let it bubble up
Contributor
Author
There was a problem hiding this comment.
Usually a java.nio.file.FileSystemException. Reason I'm catching it is just to wrap the exception to provide a more context-specific error message (and include the directory path we tried)
cmathew
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error messaging when a screenshot directory can't be created. Also ensure the idling resource is un-registered in the event of an exception.