Skip to content

Fix node-compress compiling#13

Open
elliotttf wants to merge 5 commits into
waveto:masterfrom
elliotttf:master
Open

Fix node-compress compiling#13
elliotttf wants to merge 5 commits into
waveto:masterfrom
elliotttf:master

Conversation

@elliotttf

Copy link
Copy Markdown

I've updated the compress.cc code to handle the removal of node_events.h. I'm not 100% sure Iv'e done this correctly, but the test scripts seem to work.

FWIW, I found this post helpful: [http://permalink.gmane.org/gmane.comp.lang.javascript.nodejs/28298]

@niftylettuce

Copy link
Copy Markdown

+1

@niftylettuce

Copy link
Copy Markdown

Also I noticed that after locally running node-waf configure && node-waf build that the sym link path is changed to build/Release/compress versus build/default/compress.

Can you duplicate this and do we need to fix? Ty.

@madhums

madhums commented Nov 20, 2011

Copy link
Copy Markdown

Yeah, it should be build/default/compress otherwise I am getting "Cannot find module 'compress'" error.

madhums and others added 2 commits November 20, 2011 18:23
@panosru

panosru commented Jan 26, 2012

Copy link
Copy Markdown

Will this pull request be merged or no? compress won't run with node 0.6 :(

@ghost

ghost commented May 10, 2012

Copy link
Copy Markdown

Is there anyway to use your fork @elliotttf to install a package that is dependent on compress?

@madhums

madhums commented May 10, 2012

Copy link
Copy Markdown

Yes @ecoffey-trada . You can use it like this

Put this in your package.json

"compress": "git+ssh://git://github.com/elliotttf/node-compress.git"

@ghost

ghost commented May 10, 2012

Copy link
Copy Markdown

Thanks @madhums :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants