Expose spin-summed RKS setting through C/Fortran APIs#207
Expose spin-summed RKS setting through C/Fortran APIs#207DCM-Uni-Paderborn wants to merge 1 commit into
Conversation
awvwgk
left a comment
There was a problem hiding this comment.
Can we separate the changes to the Skala implementation and core GauXC? The extension of the settings struct is a potential API change for the core library that is unrelated to Skala and is better discussed independently of the changes necessary to expose the new setting to the Fortran API for Skala.
|
Dear Sebastian, Yes, that makes sense. I split off the core GauXC part into #208 against I will keep this Thanks for pointing this out. |
6830c6e to
9081568
Compare
Dear David,
this is the follow-up to #208 for the
skalabranch. It assumes that the core C++ setting and host/device/shell-batched handling from #208 are accepted first, and only exposes that setting through the external APIs needed by downstream callers such as CP2K.Changes in this PR are now limited to:
GauXCKSSettingsThe core
IntegratorSettingsKSextension, host/device/shell-batched RKS scaling, standalone-driver keyword, and C++ integrator regression are intentionally left to #208 and are no longer duplicated here.This remains a draft until #208 is merged and the
skalabranch contains the agreed core convention.Validation:
git diff --checkskalato the C API, Fortran API, and C API test files onlyGreetings,
Thomas