Conversation
toelke
approved these changes
Sep 7, 2026
When the Wave reconciler detects missing or invalid ConfigMaps/Secrets, it now emits a Kubernetes Warning event with reason 'MissingChildren' and details of what's missing (e.g. 'missing required configmap default/foo'). Also change the webhook-path 'SchedulingDisabled' event from EventTypeNormal to EventTypeWarning, since blocking scheduling is a warning condition. Closes wave-k8s#186 (wave-k8s/wave) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
toelke
force-pushed
the
feature/emit-warning-events-missing-children
branch
from
September 7, 2026 08:54
165bf16 to
7bcb1a4
Compare
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes wave-k8s/wave#186.
When Wave detects that required ConfigMaps or Secrets are missing or incomplete, it now emits a Kubernetes
Warningevent on the affected Deployment/StatefulSet/DaemonSet, making it easy to diagnose why pods remain Pending.Changes
pkg/core/handler.gohandlePodController): Emit aWarningevent with reasonMissingChildrenwhencheckRequiredChildrenfails. Previously this path was silent.updatePodController): Change theSchedulingDisabledevent fromEventTypeNormal→EventTypeWarning, since blocking scheduling is a warning condition.pkg/core/controller_suite.goMissingChildrenwarning event is emitted in both missing-children scenarios (missing resource, missing key in projection).Example Event