Skip to content

fix(v8): consume shared-library prebuilts #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syrusakbary merged 2 commits into from
Sep 2, 2026
Merged

fix(v8): consume shared-library prebuilts #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6abe26f
fix(v8): consume shared-library prebuilts
syrusakbary Sep 1, 2026
42077d9
fix(v8): align native prebuilt consumers
syrusakbary Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ NAPI_NATIVE_TEST_OUT_DIR ?= $(abspath $(BUILD_WASIX_NAPI_DIR)/native)
NAPI_WASIX_TEST_OUT_DIR ?= $(abspath $(BUILD_WASIX_NAPI_DIR)/wasm32-wasix/release)
NAPI_V8_CTEST_ARGS ?= -E 'SandboxGlobalThisAndMarkerAreNotEnumerableForDeepFreeze'
NAPI_QUICKJS_CTEST_ARGS ?= -E 'SandboxGlobalThisAndMarkerAreNotEnumerableForDeepFreeze'
NAPI_V8_PREBUILT_VERSION ?= 11.9.7
NAPI_V8_PREBUILT_VERSION ?= 11.9.8
NAPI_V8_PLATFORM :=
NAPI_V8_DIST_ROOT ?=
NAPI_V8_CARGO_DIST_ROOT ?=
Expand All @@ -37,6 +37,8 @@ endif
else ifeq ($(UNAME_S),Linux)
ifeq ($(UNAME_M),x86_64)
NAPI_V8_PLATFORM := linux-amd64
else ifeq ($(UNAME_M),aarch64)
NAPI_V8_PLATFORM := linux-arm64
endif
endif
ifeq ($(NAPI_V8_DIST_ROOT),)
Expand Down
3 changes: 2 additions & 1 deletion build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::{
path::{Path, PathBuf},
};

const PREBUILT_V8_VERSION: &str = "11.9.7";
const PREBUILT_V8_VERSION: &str = "11.9.8";

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum V8Method {
Expand Down Expand Up @@ -391,6 +391,7 @@ fn prebuilt_asset_name() -> Result<(&'static str, &'static str), String> {
("macos", "aarch64", _) => Ok(("v8-darwin-aarch64.tar.xz", "darwin-arm64")),
("macos", "x86_64", _) => Ok(("v8-darwin-amd64.tar.xz", "darwin-amd64")),
("linux", "x86_64", "gnu") => Ok(("v8-linux-amd64.tar.xz", "linux-amd64")),
("linux", "aarch64", "gnu") => Ok(("v8-linux-arm64.tar.xz", "linux-arm64")),
("linux", "x86_64", "musl") => Ok(("v8-linux-musl-amd64.tar.xz", "linux-musl-amd64")),
("android", "aarch64", _) => Ok(("v8-android-arm64.tar.xz", "android-arm64")),
("windows", "x86_64", _) => Ok(("v8-windows-amd64.tar.xz", "windows-amd64")),
Expand Down
5 changes: 4 additions & 1 deletion tests/build-test-native.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
set -euo pipefail

PREBUILT_V8_VERSION="11.9.7"
PREBUILT_V8_VERSION="11.9.8"

if [[ $# -ne 1 ]]; then
echo "usage: $0 <test-name>" >&2
Expand Down Expand Up @@ -84,6 +84,9 @@ resolve_cached_prebuilt_v8() {
linux/x86_64)
platform_name="linux-amd64"
;;
linux/aarch64)
platform_name="linux-arm64"
;;
*)
return 1
;;
Expand Down
12 changes: 10 additions & 2 deletions v8/cmake/NapiV8Resolver.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
set(NAPI_V8_PREBUILT_VERSION "11.9.2")
set(NAPI_V8_PREBUILT_VERSION "11.9.8")
set(NAPI_V8_PREBUILT_BASE_URL
"https://github.com/wasmerio/v8-custom-builds/releases/download/${NAPI_V8_PREBUILT_VERSION}")

Expand Down Expand Up @@ -109,7 +109,15 @@ function(_napi_v8_prebuilt_strategy out_ok out_include out_library out_extra out
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND
(CMAKE_SYSTEM_PROCESSOR STREQUAL "arm64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64"))
set(_platform "darwin-arm64")
set(_asset "v8-darwin-arm64.tar.xz")
set(_asset "v8-darwin-aarch64.tar.xz")
elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND
(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64"))
set(_platform "darwin-amd64")
set(_asset "v8-darwin-amd64.tar.xz")
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND
(CMAKE_SYSTEM_PROCESSOR STREQUAL "arm64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64"))
set(_platform "linux-arm64")
set(_asset "v8-linux-arm64.tar.xz")
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND
(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64"))
set(_platform "linux-amd64")
Expand Down
Loading