fix(vmm): retry access per physical mapping on Windows - #643
Draft
HUSRCF wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #635.
Problem
VmmArena::map_nextreapplies access to the whole contiguous mapped prefix. That works around ROCm 7.2 Linux drivers which reject some valid non-zero subrange addresses, but Windows HIP 7.2 rejects the first prefix that spans two independently mapped physical allocations.Fix
hipErrorInvalidValueonly, retry access once per physical mapping;The fallback runs only while growing a VMM arena and only after the existing call fails, so successful Linux and Windows paths are unchanged.
Test plan
cargo test -p hip-bridge --lib --locked— 17 passedscripts/fmt-changed.sh mastergit diff --checkHIP_VISIBLE_DEVICES=1 cargo run --release --locked -p hip-bridge --features lab --example vmm_arena_smoke -- 0— all boundary growth, failure cleanup, teardown, and reload checks passedcargo clippy -p hip-bridge --lib --locked -- -D warningscurrently reaches three pre-existing warnings inhipfire-config/src/rocm.rs; this PR does not modify that file.Windows ROCm 7.2 validation on the reporter's RX 7900 XTX remains required before marking ready.