Enable IME on Linux/Wayland

[anshul-garg27]

Closes #9383.

Description

set_ime_allowed(true) was only being called inside the #[cfg(windows)] block in crates/warpui/src/windowing/winit/window.rs::create_window (the block that ends around line 1421 on master). On Linux/Wayland, winit's text-input plugin only sends zwp_text_input_v3.enable() to the compositor after set_ime_allowed(true) is called — without that call IME stays inactive, so non-Latin input methods (CJK in particular) appear to do nothing in Warp.

Fix

Add a parallel #[cfg(target_os = "linux")] block right after the Windows one calling the same method on the created window. macOS continues to use the native NSTextInputClient route and does not need this winit hint.

A repo-wide grep for set_ime_allowed confirms there is no other Linux-specific call site that was already covering this — the previous behaviour was "Windows-only" by oversight, not by design.

#[cfg(target_os = "linux")]
if let Ok(window) = created_window.as_ref() {
    // On Linux/Wayland, winit only sends `zwp_text_input_v3.enable()` when IME is allowed,
    // so without this call IME stays inactive and non-Latin input (CJK, etc.) is unusable.
    window.set_ime_allowed(true);
}

Testing

• cargo fmt -p warpui -- --check — passes.
• Compile-only verification possible from my checkout (Metal toolchain unavailable for full cargo nextest, mirroring Expand ~ in warp://action/new_tab?path= URLs #9277). The change is a 7-line addition that mirrors the existing Windows block exactly.
• Functional verification needs a Wayland session, which I can't run locally; CI on Linux runners should cover compilation. A maintainer with a Wayland setup could confirm IME behaviour with a CJK input method.

Coordination with #9536

PR #9536 (open) modifies the same file but inside maybe_adjust_window_vertically (lines ~1433+ on master, adding 3 lines that early-return on maximize/fullscreen). My edit lands in create_window on lines 1422–1428, which #9536 does not touch — no merge conflict expected.

Server API

No server changes.

Agent Mode

Not applicable.

Changelog Entries

CHANGELOG-BUG-FIX: IME (input method) now activates on Linux/Wayland, restoring CJK and other non-Latin input that had been silently broken since first launch.

[oz-for-oss]

@anshul-garg27

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @vorporeal.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR enables winit IME handling for Linux windows by calling set_ime_allowed(true) after successful window creation, matching the existing Windows setup path and allowing Wayland text-input activation for CJK/non-Latin input.

Concerns

• No blocking correctness or security concerns found in the changed hunk.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[vorporeal]

Functional verification needs a Wayland session, which I can't run locally; CI on Linux runners should cover compilation. A maintainer with a Wayland setup could confirm IME behaviour with a CJK input method.

i don't want to merge a prospective fix without confirmation that this fixes the reported issue; can you comment on the linked bug and ask someone there, who has experienced/reported this, to validate that this actually fixes the problem?