Skip to content

Enable git operations in code review feature#9597

Open
exzshao wants to merge 1 commit intomasterfrom
edward/flip-git-ops-ff-prod
Open

Enable git operations in code review feature#9597
exzshao wants to merge 1 commit intomasterfrom
edward/flip-git-ops-ff-prod

Conversation

@exzshao
Copy link
Copy Markdown
Contributor

@exzshao exzshao commented Apr 30, 2026

This change enables the git_operations_in_code_review feature flag in the production environment. This allows the code review feature to perform Git operations.

  • The feature flag was added to the default features in Cargo.toml.
  • The feature flag was removed from the PREVIEW_FLAGS list in warp_features/src/lib.rs.

@cla-bot cla-bot Bot added the cla-signed label Apr 30, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Apr 30, 2026

@exzshao

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and posted feedback on this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR promotes GitOperationsInCodeReview by enabling the corresponding Cargo feature in the default feature set and removing the runtime flag from PREVIEW_FLAGS. Preview/Dev/Local builds still receive the behavior through the default Cargo feature, while stable production builds now initialize the runtime feature flag through the existing enabled_features() bridge.

Concerns

  • No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant