fix: isolate unrenderable glyph failures#9447
Conversation
Co-Authored-By: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
|
Hitting this same bug on Linux (WGPU) — happy to share an independent repro and validation in case it helps move this out of draft. Repro (reliable):
The whole prompt + surrounding region blacks out. Scrolling forces a redraw and the previous content reappears, which is what tipped us off that the buffer was intact and only the render layer was being dropped. Logs match exactly what this PR addresses: The same glyph key ( Validation: I cherry-picked this PR's commit onto current The underlying "why does U+2717 fail to rasterize at all" question (font fallback gap) is separate from this fix, and I agree with the scope here — a single bad glyph shouldn't be able to take down an entire render layer regardless of cause. Any chance this could be moved out of draft? It's a daily annoyance for Linux users with themes that show status glyphs in the prompt. |
|
Seems to be replaced by #13144 which probably solved your problem? |
Closes #9372
Summary
Validation
cargo test --manifest-path /workspace/warp/Cargo.toml -p warpui rendering::glyph_cache --libcargo check --manifest-path /workspace/warp/Cargo.toml -p warpui --libNotes
cargo fmt --manifest-path /workspace/warp/Cargo.toml --allcould not run becauserustfmtis not installed for the stable toolchain in this sandbox.