Clarify Oz/warpctrl CLI install command palette labels#13155
Conversation
The 'Install Oz CLI command' / 'Uninstall Oz CLI command' (and the warpctrl equivalents) command palette entries were confusing: the bundle's Contents/Resources/bin (containing the oz/warpctrl wrappers) is already appended to PATH for shells Warp spawns (extra_path_entries), so these commands work inside Warp without installing. The install action only symlinks them into /usr/local/bin for use *outside* of Warp. Relabel the four entries to make that explicit, and align the install/uninstall success toasts with the same 'globally / outside of Warp' framing. Co-Authored-By: Warp <agent@warp.dev>
|
@warp-dev-github-integration[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR clarifies macOS command palette labels and CLI install/uninstall success toasts for Oz and Warp Control, emphasizing that installation is global for use outside Warp. No spec context was available, and the security pass found no security-specific concerns.
Concerns
- This is a user-facing copy change in the command palette and success toasts, but the PR does not include screenshots or a screen recording demonstrating the updated labels/toasts end to end. For this user-facing change, please include screenshots or a screen recording from macOS demonstrating it working end to end.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
Thanks for the review. The one suggestion is end-to-end macOS screenshots of the updated labels/toasts. I can't capture those in this environment: the change only touches The change is copy-only (label + toast strings; no logic change) and Co-Authored-By: Warp agent@warp.dev |
Description
Clarifies the macOS-only "Install/Uninstall Oz CLI command" command palette entries (and the Warp Control /
warpctrlequivalents), which a teammate found confusing.Background. The app bundle's
Contents/Resources/bin— which holds theoz/warpctrlwrapper scripts — is automatically appended toPATHfor shells Warp spawns (extra_path_entries()inapp/src/terminal/local_tty/shell.rs, threaded throughWARP_PATH_APPEND). Sooz/warpctrlalready work inside Warp without installing anything. The install actions only symlink them into/usr/local/bin(install_oz/install_warpctrlinapp/src/workspace/cli_install.rs) so they're available outside Warp (Terminal.app, iTerm, VS Code's integrated terminal, SSH, scripts/cron, etc.). The old "Install … CLI command" label gave no hint of that distinction.Changes
warpctrl messaging + install logic review (requested)
Verified. The warpctrl install logic is correct and intentionally differs from Oz: Oz symlinks the shared binary directly (its subcommands live in the normal arg parser), whereas warpctrl symlinks a bundled wrapper that injects the hidden
--warpctrlflag (which selects its separate parser). Both wrappers ship inContents/Resources/bin, so both are auto-injected into Warp-spawned shells — meaning the same "global vs. in-Warp" framing applies. Only the user-facing messaging needed clarifying, which this PR does.Testing
Copy-only change to macOS-gated UI strings (
#[cfg(target_os = "macos")]); no logic changed, so no new automated test is warranted.rustfmt --checkpasses on both edited files.UI / computer-use verification not performed: these entries are macOS-only and this PR was prepared on a Linux runner, where the code is
cfg-compiled out and the command palette entries can't be rendered. Worth a quick visual check on macOS during review.I have manually tested my changes locally with
./script/runAgent Mode
CHANGELOG-IMPROVEMENT: Clearer command palette labels for installing/uninstalling the Oz and Warp Control CLIs (they now describe global, outside-Warp use vs. in-Warp use).
Slack thread: https://warpdev.slack.com/archives/C0BCE7AELJ2/p1782679562471409?thread_ts=1782679562.471409&cid=C0BCE7AELJ2
Co-Authored-By: Warp agent@warp.dev