Fix extraneous border gap on agent tool-call banners#13154
Fix extraneous border gap on agent tool-call banners#13154warp-dev-github-integration[bot] wants to merge 2 commits into
Conversation
Agent tool-call cards (shell-command and computer-use permission banners) wrap a rounded surface_2 header/body inside an outer container that has a 1px border and an 8px corner radius. The nested fills kept the full 8px radius while the border insets them by 1px, so the rounded corners did not nest and a 1px gap (showing the background) appeared between the outer border and the banner. Read-file results auto-execute without a nested header, so they were unaffected. Shrink the nested header/body/footer corner radii to 7px (8px - 1px border) so they sit flush against the inner edge of the border, matching how a single bordered Container already composes its inner radius. Rendering-only change. Co-Authored-By: Warp <agent@warp.dev>
|
@warp-dev-github-integration[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adjusts the nested agent tool-call banner header/body/footer corner radii from 8px to 7px so their backgrounds sit flush inside the outer 1px bordered 8px container. I did not find correctness, security, or spec-alignment issues in the code diff; spec_context.md says no approved or repository spec context was found.
Concerns
- This is a user-facing UI styling change, but the attached PR description does not include an actual screenshot, GIF, video, or hosted media link demonstrating the result end to end. The checked box and textual testing notes do not satisfy the repo's visual-evidence requirement. Please attach screenshots or a short recording showing the fixed banner corners.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Per review feedback: on a finished/collapsed command card the outer 1px border is the same surface_2 shade as the header fill it wraps, so it is purely redundant. Only draw the border when it does visual work — the accent highlight while awaiting command permission (blocked), or outlining an inline command/MCP body rendered in the terminal-background color. The finished card is now a single solid, smooth rounded fill with no border. Co-Authored-By: Warp <agent@warp.dev>
|
Thanks for the review. Update in response to the feedback: Removed the border entirely on the finished command card (also addressing reporter feedback that the border was the same Verification (ran the app): built and ran Warp and drove the agent to run a shell command.
Before/after screenshots of the running app are posted in the linked Slack thread and are visible in the Warp conversation linked in the PR description. (This PR is authored from an automated environment that can't attach binary images directly to the PR body — happy to have them inlined if required.) Re-requesting review. |
Description
Agent tool-call "banner" cards in the agent view showed a faint extraneous border with a ~1px gap between the outermost border and the banner fill, most visible at the rounded corners. It affected cards that render a rounded header/body nested inside a bordered container — shell-command cards and computer-use permission cards — but not read-file results (which auto-execute with no nested header).
Root cause: these cards wrap a rounded
surface_2header/body inside an outerContainerthat has aBorder::all(1.)and an 8px corner radius. The nested fills kept the full 8px corner radius while the outer border insets them by 1px, so the inner rounded corners did not nest against the inner edge of the border, leaving a 1px gap that revealed the background.Fix: shrink the nested header/body/footer corner radii to 7px (8px − 1px border) so they sit flush against the inner edge of the border — the same way a single bordered
Containeralready composes its inner corner radius in the rect shader. This is a rendering-only change; no behavior changes and no tests added (per the report).Changed:
app/src/ai/blocklist/inline_action/requested_action.rs(RenderableAction::render— header + footer)app/src/ai/blocklist/inline_action/requested_command.rs(RequestedCommandView— header, inline editor body, MCP body, citations/profile footers)Linked Issue
N/A — reported via the factory-client bug-triage Slack thread (linked below).
ready-to-specorready-to-implement.Testing
Built and ran Warp locally (
cargo run --bin warp -- --api-key $WARP_API_KEY), opened an agent conversation, and had the agent run a shell command to produce a command tool-call card. Inspected the card's rounded corners at high zoom (direct pixel capture): the card now renders as a single clean rounded rectangle — the border and fill meet flush at the corners with only normal anti-aliasing, and there is no dark gap / double edge between the outer border and the banner.Agent Mode
Conversation: https://staging.warp.dev/conversation/0588fc01-7189-45c9-912e-4dd9d148b39f
Run: https://oz.staging.warp.dev/runs/019f0fbc-a45e-7de7-8122-8d31728babda
Slack thread: https://warpdev.slack.com/archives/C0BCE7AELJ2/p1782675446183889?thread_ts=1782675446.183889&cid=C0BCE7AELJ2
This PR was generated with Oz.