Clean up TabCloseButtonOnLeft feature flag#13146
Open
oz-for-oss[bot] wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@oz-for-oss[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Overview
This PR removes the TabCloseButtonOnLeft feature flag and makes the tab close button position setting and behavior always available.
Concerns
- Missing visual evidence: this cleanup changes user-visible settings and tab-close-button behavior, but the PR description does not include screenshots or a screen recording demonstrating the setting and resulting tab UI end to end. For this user-facing change, please include screenshots or a screen recording before merge.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cleanup of the
TabCloseButtonOnLeftfeature flag.This PR was generated by the feature flag cleanup workflow.