Repository navigation
Apply V4A edits that only delete a blank line - #111
Draft
Conversation
Joining one matched blank line is an empty string, so a deletion whose replacement is empty was counted as a no-op and never applied. Compare the line sequences instead.
warp-agent-staging
Bot
added
the
factory:exp-context-window-size
Author
|
This PR was generated with Warp. Comment   |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A forwarded V4A hunk that only deletes one blank line was counted as a no-op. Joining that matched line is
"", which equals an empty replacement, so the deletion never applied.Compare the line sequences instead. Adding a blank line already applied. Replacing a blank line with a blank line stays a no-op.
This is the client half of the server change that now forwards those hunks: https://github.com/warpdotdev/warp-server-for-benchmarks/pull/4210