Repository navigation
Apply a V4A deletion of one blank line - #109
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Joining one blank line yields the same string as an empty insertion, so the no-op check dropped a real deletion. Compare lines instead.
warp-agent-staging
Bot
added
the
factory:exp-context-window-size
Author
|
This PR was generated with Warp. Comment   |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A V4A deletion of one blank line was ignored as a no-op. Joining that line produces
"", the same string as an empty insertion, so the matcher dropped the edit even when the server sent it. The check now compares lines.Server side of the same bug: https://github.com/warpdotdev/warp-server-for-benchmarks/pull/3922
Linked Issue
ready-to-specorready-to-implement.Tracked in Linear as REMOTE-1.
Testing
./script/runThis is a matcher change, not a UI change.
cargo test -p ai --lib diff_validation::tests::test_v4apassed locally, including new cases for deleting and inserting one blank line.cargo clippy -p ai --lib --tests -- -D warningspassed.rustfmt --checkpassed.CHANGELOG-NONE