Skip to content

Rename /oz-review command to /warp-agent-review - #46

Merged
moirahuang merged 3 commits into
mainfrom
factory/warp-agent-review-rename
Aug 24, 2026
Merged

Rename /oz-review command to /warp-agent-review#46
moirahuang merged 3 commits into
mainfrom
factory/warp-agent-review-rename

Conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Summary

Renames the advertised PR-review comment command from /oz-review to /warp-agent-review, per the org-wide rename. This repo hosts the only trigger surface that is literally a GitHub Actions workflow (issue_comment body match), separate from the warpdotdev/oz-for-oss webhook router, which is being renamed under separate cover.

/oz-review keeps working as an unadvertised backwards-compatible alias — no hard cutoff — per explicit instruction from the requester.

Changes

  • examples/review-pr.yml (source of truth): widened the issue_comment trigger condition from an exact-equality check against /oz-review to accept either /warp-agent-review or /oz-review. Added a short comment explaining why the old command is retained. Updated the usage/prose comments to advertise /warp-agent-review.
  • .github/workflows/review-pr.yml and consumer-workflows/review-pr.yml: regenerated from the example via npm run gen-workflows (these are generated files; do not hand-edit).
  • README.md: updated the two prose references to the trigger command.

Judgment call — flagging for reviewer

The trigger condition matches github.event.comment.body with exact string equality. I widened it to body == '/warp-agent-review' || body == '/oz-review' (the minimal change to satisfy "accept both spellings"). I deliberately did not additionally relax it to tolerate surrounding whitespace or trailing text (e.g. /warp-agent-review please), even though the oz-for-oss router reportedly does something like that — that felt like scope creep beyond a rename, and changing matching semantics for existing exact-match consumers deserves its own look. Happy to widen further if that's preferred.

Verification

  • examples/review-pr.yml, .github/workflows/review-pr.yml, and consumer-workflows/review-pr.yml parse as valid YAML (verified with the yaml package) and the generated if: expression round-trips correctly with both command strings.
  • npm run lint (ESLint) — clean.
  • npx prettier --check on the changed files — clean.
  • npm test (vitest) — 27/27 passing (unaffected by this change; no code paths touched).
  • Not run: the repo's act-based e2e workflow test (AGENTS.md) and actionlint — neither docker nor actionlint was available in this environment. The YAML parse + generator round-trip is the closest available substitute for confirming the if: expression is well-formed.

Advertise /warp-agent-review as the PR-review comment command across
the README and generated workflow templates. /oz-review keeps working
as an unadvertised backwards-compatible alias so existing muscle
memory and bookmarked comments don't break.

The change is authored in examples/review-pr.yml (the source of
truth) and propagated to .github/workflows/review-pr.yml and
consumer-workflows/review-pr.yml via npm run gen-workflows.
@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-factory on this PR to send it follow-up work.

View run View conversation View on Slack

wilson added 2 commits August 21, 2026 15:23
The example workflow already carries this note; the live reusable
workflow is the one a maintainer is most likely to prune the alias
from, so it needs the reason too.
@moirahuang
moirahuang marked this pull request as ready for review August 21, 2026 15:29
@moirahuang
moirahuang requested a review from acarl005 August 21, 2026 15:30
@moirahuang
moirahuang merged commit d5c5a5c into main Aug 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants