fix: bump nanoid to 3.3.18 to resolve GHSA-2v37-7h3g-55p8 - #45
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
fix: bump nanoid to 3.3.18 to resolve GHSA-2v37-7h3g-55p8#45warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Update the transitive, dev-scoped nanoid dependency (pulled in by postcss via prettier-eslint) from 3.3.16 to 3.3.18, fixing an infinite loop in customAlphabet/customRandom when called with size 0 that could hang the calling thread (DoS). Lockfile-only change; nanoid has no first-party call sites in this repo. Co-Authored-By: Warp <agent@warp.dev>
Contributor
Author
|
@/tmp/pr_comment_QPNgl5 |
![warp-agent-staging[bot]](https://avatars.githubusercontent.com/in/2196476?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Overview
Lockfile-only bump of the dev-scoped transitive nanoid from 3.3.16 to 3.3.18, clearing GHSA-2v37-7h3g-55p8. The change is correct and verified; one policy question is left for a maintainer.
Concerns
package.json(untouched) — question: the repo's two previous transitive security fixes pinned a floor with anoverridesentry (undici,brace-expansion), while this one relies onpostcss's^3.3.16range resolving upward. Nothing regresses today — a cleannpm ciand a--package-lock-onlyreinstall both reproduce3.3.18— but a future lock regeneration has no explicit invariant holding the floor. If you want the same guarantee as the earlier fixes, add"nanoid": ">=3.3.18 <4.0.0"tooverrides; otherwise this is fine as-is.
Verdict
Checks: build pass, tests pass (27/27), CI green (8/8), visual proof n/a
Found: 0 critical, 0 important, 0 suggestions, 0 nits, 1 question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the transitive
nanoiddependency from3.3.16to3.3.18to resolve GHSA-2v37-7h3g-55p8 (CVE-2026-67213, GitHub-reported severity: high), reported via Dependabot alert #44.The advisory describes an infinite loop in
nanoid'scustomAlphabet/customRandomfunctions when called with asizeof0, which can hang the calling thread (denial of service).nanoidis a dev-scoped, transitive dependency here — it arrives viavitest -> vite -> postcss -> nanoid(confirmed withnpm ls nanoid --all). It does not appear anywhere insrc/,dist/, orscripts/(no first-party call sites), so this repo has no real runtime exposure to the vulnerability; this change clears the alert. GitHub had already auto-dismissed the Dependabot alert for the same reason (dev-scoped), but the fix still belongs in the lockfile.Tracked by DEVX-8511.
Changes
package-lock.json:nanoid3.3.16→3.3.18(patched version for the 3.x line; compatible with postcss's^3.3.16range). Resolved vianpm update nanoid; nooverridesentry was needed. Lockfile-only change — no source,dist/, or workflow files were touched.Verification
npm ci— passednpm run lint— passed (no errors)npm run format:check— passed (All matched files use Prettier code style!)npm test— passed (vitest run, 27/27 tests passed)node_modules/nanoidresolves to3.3.18in the lockfile and no other dependency was silently upgraded.dist/,.github/workflows/, andconsumer-workflows/are unchanged, as expected for a dependency not present in the bundle.