Repository navigation
docs: explain delegated integration setup for factories - #961
Draft
warp-agent-staging[bot] wants to merge 2 commits into
Draft
warp-agent-staging[bot] wants to merge 2 commits into
warp-agent-staging[bot] wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
This PR was generated with Warp. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this feature does
Delegated setup lets someone with integration-connect permission in Warp ask an external administrator to authorize a workspace connection without giving that administrator a Warp account. The requester then finishes factory-specific setup. This continuously deployed web flow has no verified client release version; checked-in production rollout was verified at server revision
8ce1fe06b4ae14a726975a3ef540a81f0424abba.Summary
Document setup when the factory creator isn't an external platform administrator. Keep the shared procedure in Connect your factory and the differences on the seven existing provider pages. No new pages, URL moves, navigation changes, or source/tooling edits.
Changes
Content design plan
Reader and job: A factory creator who lacks external administrator access, plus the administrator receiving the request. Complete approval and return the requester to the remaining factory setup.
Gap today: Setup guidance conflates external approval with factory configuration and personal account linking. Shared link management is duplicated or missing.
Change: Update existing pages only. The canonical connection page owns the shared procedure; provider pages own approval requirements and handback; quickstart and troubleshooting link to them. Preserve the source chooser, usage, automation, and security jobs of these pages.
Content types and skills: Existing combined feature pages (
draft_feature_docandfeature-doc.md), existing quickstart (draft_quickstartandquickstart.md), troubleshooting (draft_troubleshootingandtroubleshooting.md), and a one-sentence conceptual-page update. Use procedural rules within setup sections; no new page scaffold.Coverage: All seven first-class providers, request recovery, and the workspace/factory/account boundary. Excludes self-managed GitLab delegation, a new FAQ, and a broad rewrite of legacy platform setup.
Gate 0: Human-requested update. The delegation and provider rollout checks found the documented gated flows enabled in checked-in production configuration at the source revision above. Teams transport availability is runtime-dependent, not a rollout flag. This is source/configuration evidence, not a live product check; availability and tenant-policy checks remain below.
Unverified claims
This is the one inline VERIFY marker, in
slack.mdx, Connect the factory. Exercise the real restricted-user flow before merging; the draft does not promise end-to-end non-admin installation.Documentation risk
Risk: engineering-review-required
Rationale: Adds integration setup, permission and bearer-link security claims. Slack handback and live external-policy checks remain open.
Source files consulted: warp-server/logic/integration_setup.go, integration_setup_delegation.go, integration_setup_oauth.go, integration_setup_completion.go, integration_setup_gitlab.go, integration_setup_jira.go, integration_setup_microsoft_teams.go, azure_devops_manager_setup.go, azure_devops_manager_setup_link.go; client/packages/factory/src/components/integration-setup/; client/packages/factory/src/pages/FactorySettings/; slack/slack_provision.go; test/integration/integration_setup_oauth_completion_test.go (all at 8ce1fe06b4ae14a726975a3ef540a81f0424abba).
Requested engineering reviewers: none
Engineering review status: pending
Docs override: none
The source-owner resolver returned no owner for the delegation, approval, and shared UI paths. No fallback reviewer was requested.
Verification
npm run typecheck: 0 errors, 7 existing hints.npm run test:heading-vars: 5 tests passed.npm run build: passed, 401 pages. Existing warnings: deprecated Markdown plugin configuration, empty i18n collection,/404route conflict, and large chunks.npm run test:heading-tocs: passed, 3,399 entries across 401 HTML files.npm run test:homepage-json-ld: passed.python3 .agents/skills/check_for_broken_links/check_links.py --internal-only: passed; no broken internal links.check_links.py --output /tmp/delegated-links-full.jsonwithrequestsinstalled: 4,523 internal and 1,765 external links checked; one unchanged external WSL link returns 404, with 13 bot-blocked URLs reported separately. No introduced broken links.python3 .agents/skills/style_lint/style_lint.py --changed --output /tmp/delegated-style.json: 11 files, 43 warnings (44 on the same files at base). Remaining warnings concern quoted UI/proper names and glossary coverage; three new signatures are Azure DevOps, Apps, and Connect to Warp.python3 .agents/skills/validate_ui_refs/validate_ui_refs.py --changed --all: 11 files, 0 issues. Snapshot:warpdotdev/warp@3e2b62975ada8119f495f136f22474e1b26fa278.check_compression_contract.py FILE --content-type TYPE: passed for all 11 edited pages.trunk checkandtrunk fmt: unavailable (trunk: command not found).git diff origin/main...HEAD --check: passed.check_pr_contract.py --body: passed, including the single VERIFY marker.check_pr_body.py --require-lead-section "## What this feature does": authored text passed. The complete body triggers a repetition false positive on the required generated screenshot block's identical alt text and caption; that block is preserved verbatim.Editorial verdict: Preserve each existing page's job. Shared link lifecycle lives once; provider pages retain the decisions and remaining actions needed at handback. The deletion-only pass removed framing and compressed repeated default-automation descriptions into links to their owning provider sections. No operational facts were removed without a destination. The only added comment is the accounted-for Slack VERIFY marker.
Computer-use screenshots (2)
Canonical "Request setup from an administrator" section with permission paragraph, numbered steps, and Caution callout
Slack "Connect the factory" section showing the limited workspace-approval handback wording