Improve hardcoded thickness values in HGCAL TPG #6
Draft
jbsauvan wants to merge 15 commits into
Draft
Conversation
jbsauvan
force-pushed
the
improve-hardcoded-v19
branch
from
341fdf9 to
3dc43f9
Compare
waredjeb
force-pushed
the
fix_V19_HLT_RECO_PR
branch
3 times, most recently
from
a4b8a8b to
1eae11c
Compare
waredjeb
pushed a commit
that referenced
this pull request
Sep 29, 2025
* first try distributing process Modifiers of Cleaning step * disable finale state radiation for mu->mu embedding * update center of mass energy for run3 * implement correct ModifierChain for tau embedding process modifiers * revert some changes * set all process modifier for tau embeddign cleaning step * Introduce special cleaning and simulation process modifier * add process modifiers for sim gen step * Set process modifiers for reco sim step * add process modifier for tau embedding merging step Those "toReplaceWith" modifiers need to be applied as late as possible e.g. in StandardSequences.Reconstruction_Data_cff. This is to avoid collisions with other modules that are cloned and modified versions from the original modules or "toModify" modifier calls that try to modify the original modules. They throw an exeption if they want to do this on the replaced merger modules. * add autoNANO option for the tau embedding nanoaod files * adjust test cmsDriver commands to work with the new process modifiers --------- Co-authored-by: Christian Winter <c.winter@kit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve hardcoded thickness values in HGCAL TPG: