Skip to content

build(deps): bump pdfviewer from 1.0.0-alpha18 to 1.0.0-beta01 - #15

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/gradle/pdfviewer-1.0.0-alpha19
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/gradle/pdfviewer-1.0.0-alpha19

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bumps pdfviewer from 1.0.0-alpha18 to 1.0.0-beta01.
Updates androidx.pdf:pdf-viewer-fragment from 1.0.0-alpha18 to 1.0.0-beta01

Updates androidx.pdf:pdf-document-service from 1.0.0-alpha18 to 1.0.0-beta01

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update java code labels Aug 17, 2026
@wangzhishou

Copy link
Copy Markdown
Owner

Rebasing this onto current main.

Context for why it sat for a month: this repository had no workflow that built pull requests. CI only ran on tag pushes, so a dependency bump could only be verified by hand, and the whole batch stalled.

That is fixed as of 269a5f86.github/workflows/pr-check.yml now builds :app:assembleFossUniversalDebug on every PR. Asking dependabot to rebase below so the new check actually runs on this branch. If it comes back green, it gets merged.

@dependabot rebase

Bumps `pdfviewer` from 1.0.0-alpha18 to 1.0.0-beta01.

Updates `androidx.pdf:pdf-viewer-fragment` from 1.0.0-alpha18 to 1.0.0-beta01

Updates `androidx.pdf:pdf-document-service` from 1.0.0-alpha18 to 1.0.0-beta01

---
updated-dependencies:
- dependency-name: androidx.pdf:pdf-document-service
  dependency-version: 1.0.0-alpha19
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: androidx.pdf:pdf-viewer-fragment
  dependency-version: 1.0.0-alpha19
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title build(deps): bump pdfviewer from 1.0.0-alpha18 to 1.0.0-alpha19 build(deps): bump pdfviewer from 1.0.0-alpha18 to 1.0.0-beta01 Sep 16, 2026
@dependabot
dependabot Bot force-pushed the dependabot/gradle/pdfviewer-1.0.0-alpha19 branch from eb226bd to 851b8f1 Compare September 16, 2026 08:13
wangzhishou added a commit that referenced this pull request Sep 16, 2026
- github-actions 更新分组, 否则每个 action 各开一个 PR。
- 忽略 pdfviewer >= 1.0.0-beta01: 它依赖的 androidx.pdf:pdf-core:1.0.0-beta01
  声明 minSdk 28, 本项目 minSdk 24, 新增的 pr-check 工作流已用真实构建证明
  processFossUniversalDebugMainManifest 会失败(PR #15)。
@wangzhishou

Copy link
Copy Markdown
Owner

Closing this — the new PR check built it and it does not compile, for a reason worth recording.

CI run 35072635989:

> Task :app:processFossUniversalDebugMainManifest FAILED
Manifest merger failed : uses-sdk:minSdkVersion 24 cannot be smaller than version 28
declared in library [androidx.pdf:pdf-core:1.0.0-beta01]

pdfviewer 1.0.0-beta01 pulls in androidx.pdf:pdf-core:1.0.0-beta01, which declares minSdk 28. This project ships minSdk 24, so merging this would silently drop every Android 7.x and 8.x device — the build does not even get as far as a warning.

There are only three ways forward, and all of them are product decisions rather than dependency bumps:

  1. Stay on alpha18 (what this PR does today).
  2. Bump minSdk to 28 — deliberate, and it costs real device coverage.
  3. tools:overrideLibrary="androidx.pdf.core" — forces the manifest through and moves the failure to runtime on exactly the devices that cannot run it. Not doing this.

I have added an ignore rule for pdfviewer >= 1.0.0-beta01 in .github/dependabot.yml so this does not reopen every week. If someone wants to take the minSdk question, open an issue and we will decide it there.

(This PR is also the first thing the new pr-check workflow ever failed — which is a decent advertisement for having one.)

@dependabot @github

dependabot Bot commented on behalf of github Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/gradle/pdfviewer-1.0.0-alpha19 branch September 16, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant