Fix of parameters sorting#8
Open
ilnarb wants to merge 1 commit into
Open
Conversation
The following issues have been fixed 1. wrong result of comparison due 'rc = -1;' after equality `complete` on min len of two, for example, key=value&key=value1 will lead to key=value1&key=value 2. RFC 3986 says params are case-sensitive, but ngx_http_sorted_querystring_cmp_parameters uses ngx_strncasecmp 3. the first if compare only min len, so the names are not sorted lexicographically for certain cases, for example key=value, key1=value1, coz '1' < '='
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following issues have been fixed
completeon min len of two, for example, key=value&key=value1 will lead to key=value1&key=value