Skip to content

feat: Wiring OIDC env vars#213

Open
jthakkar04 wants to merge 5 commits into
v2from
jthakkar/oidc-wiring
Open

feat: Wiring OIDC env vars#213
jthakkar04 wants to merge 5 commits into
v2from
jthakkar/oidc-wiring

Conversation

@jthakkar04

@jthakkar04 jthakkar04 commented Jun 11, 2026

Copy link
Copy Markdown

Adds an oidc source type to the env-var resolver that maps the four spec.wandb.oidc secret selectors onto the gorilla container as secretKeyRef env vars, emitting nothing when OIDC is unconfigured, so the server-manifest's type: oidc entries actually reach the app and enable OIDC/SSO login

Relevant PR: https://github.com/wandb/core/pull/45652

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ed5ecee-e397-49cc-89ae-dba48c9d3bfd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jthakkar/oidc-wiring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread internal/controller/reconciler/pods.go Outdated
@jthakkar04 jthakkar04 force-pushed the jthakkar/oidc-wiring branch from 7bb9c89 to eb1840a Compare June 15, 2026 14:15
Emit a secretKeyRef when a custom-resource field resolves to a SecretKeySelector, wiring OIDC (spec.wandb.oidc) into the app without a dedicated source type.
@jthakkar04 jthakkar04 force-pushed the jthakkar/oidc-wiring branch from eb1840a to 026a9c7 Compare June 15, 2026 15:29
jthakkar04 and others added 2 commits June 16, 2026 14:19
Emit a secretKeyRef when a custom-resource field resolves to a SecretKeySelector, wiring OIDC (spec.wandb.oidc) into the app without a dedicated source type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants