Skip to content

docs: Design docs for review#204

Open
danielpanzella wants to merge 5 commits into
v2from
danielpanzella/design-docs
Open

docs: Design docs for review#204
danielpanzella wants to merge 5 commits into
v2from
danielpanzella/design-docs

Conversation

@danielpanzella

Copy link
Copy Markdown
Contributor
  • Infrastructure version enforcement driven by wandb server manifest
  • Enable multiple instances of each infra type
  • Version compatability enforcement for operator and server manifest

danielpanzella and others added 5 commits April 29, 2026 13:40
Adds an architectural design doc and a detailed implementation plan for
making the W&B server manifest the source of truth for per-component
infrastructure versions: a managed-infra deploy target and an
external-infra minimum, with the validating webhook hard-rejecting
upgrades whose external infrastructure is below the floor.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
v2 is still in alpha, so the existing user-facing version field on
ManagedClickHouseSpec can be dropped without a deprecation window.
Removes the tombstoning language from both docs and trims the matching
open question.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a76ec640-1434-4531-bb17-e6baed9338d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch danielpanzella/design-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

## 8. Open questions

- **MinIO/S3 version reporting.** Real S3 has no version. For MinIO we can read the `Server` header; for AWS/GCS we should record a marker (e.g. `"s3"` or `"gcs"`) and skip the `minVersion` check. The exact marker scheme should be agreed before implementation.
- **Kafka version detection.** `ApiVersions` returns supported API ranges, not a clean broker version string. We will likely have to derive a representative version from the highest supported APIs, or use vendor-specific endpoints. Open as to which library to use.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a lot about bufstream, but if it's the long-term way forward, will this approach work similarly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants