Add --no-alternate-screen (-X) flag#417
Open
ev1lm0nk3y wants to merge 2 commits into
Open
Conversation
- Implement --no-alternate-screen (alias -X) to disable switching to the alternate screen buffer. - Add SIGINT and SIGTERM handling to ensure terminal state is restored on exit. - Ensure AwaitFirstByte is called for all stream inputs to protect interactive prompts. - Refactor twin library to support screen options. - Update public embedding API with NoAlternateScreen option.
Owner
|
Do you think you could split this into two PRs?
That would simplify review conversations a lot! |
Contributor
Author
|
Absolutely! I'll get to it after the holiday weekend
…On Sat, May 23, 2026, 7:24 AM Johan Walles ***@***.***> wrote:
*walles* left a comment (walles/moor#417)
<#417 (comment)>
Do you think you could split this into multiple PRs?
- One for SIGINT / SIGTERM handling
- One for ensuring AwaitFirstByte is called for all stream inputs to
protect interactive prompts.
- One for skipping the alternate screen
That would simplify review conversations a lot!
—
Reply to this email directly, view it on GitHub
<#417 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKXAAEDOCIVUQ4A3RUDECD44GYDVAVCNFSM6AAAAACZFIWCQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMRVGY2TCMRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
walles
added a commit
that referenced
this pull request
May 29, 2026
This is the signal handling part of #417.
walles
changed the title
Owner
|
I merged signal your signal handling changes separately and dropped them from this PR. I made sure your name ended up in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experiencing issues when
moorwas being used when interactive prompts were required by external cli tools.