Adding credentialOffer to VPR - #705
Open
eric-schuh wants to merge 1 commit into
Open
Conversation
…ipating in an exchange.
eric-schuh
requested review from
PatStLouis,
TallTed,
dlongley and
msporny
as code owners
August 18, 2026 17:14
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
eric-schuh
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
TallTed
reviewed
Aug 25, 2026
| description: A URL that can be utilized for interacting with the service for the purposes of responding to the Verifiable Presentation Request. | ||
| "credentialOffer": | ||
| type: array | ||
| description: An optional parameter that informs a recipient which potential VCs might be issued if the VPR is responded to. This can also be used by a responder o provide their own VPR with preferencial constraints as to which VC(s) they would prefer to receive. |
Member
There was a problem hiding this comment.
Suggested change
| description: An optional parameter that informs a recipient which potential VCs might be issued if the VPR is responded to. This can also be used by a responder o provide their own VPR with preferencial constraints as to which VC(s) they would prefer to receive. | |
| description: An optional parameter that informs a recipient which potential VC(s) might be issued if the VPR is responded to. A responder can also use this to provide their own VPR with preferential constraints on the VC(s) they would prefer to receive. |
TallTed
reviewed
Aug 25, 2026
| @@ -99,6 +99,43 @@ components: | |||
| "serviceEndpoint": | |||
| type: string | |||
| description: A URL that can be utilized for interacting with the service for the purposes of responding to the Verifiable Presentation Request. | |||
Member
There was a problem hiding this comment.
Suggested change
| description: A URL that can be utilized for interacting with the service for the purposes of responding to the Verifiable Presentation Request. | |
| description: A URL that can be used for interacting with the service for the purpose of responding to the Verifiable Presentation Request. |
TallTed
reviewed
Aug 25, 2026
| type: string | ||
| "proof": | ||
| type: array | ||
| description: Results from verifying the proof objects if any. |
Member
There was a problem hiding this comment.
Suggested change
| description: Results from verifying the proof objects if any. | |
| description: Results, if any, of verifying the proof objects. |
TallTed
reviewed
Aug 25, 2026
| description: Results from verifying the proof objects if any. | ||
| items: | ||
| type: object | ||
| description: Information about what proofs are used by the VC being described. |
Member
There was a problem hiding this comment.
Suggested change
| description: Information about what proofs are used by the VC being described. | |
| description: Information about the proofs used by the VC being described. |
kezike
approved these changes
Aug 25, 2026
kezike
left a comment
kezike
left a comment
Collaborator
There was a problem hiding this comment.
@eric-schuh This looks great! I like the credentialOffer example, and would also appreciate an example illustrating a VPR sent by the holder to provider their “preferential constraints” on the VC format they would like to receive. This would be useful for wallet implementers. Approving, as I see that as a non-blocker, but I’d like for us to track it in an issue if we don’t capture it in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #689:
It adds a "credentialOffers" optional parameter to VPRs that allows a recipient to advertise which credential formats may result from the current interaction. It also provides the initial requester of a credential the ability to inform the receiving party which of the advertised formats they would like to receive the credential in, if possible.
As of right now this PR does not include any additional parameters such as "requestedGroup", which was mentioned in one of the comments on the original issues.