Repository navigation
Rename 'template' field to 'payload' for all suites. - #88
Merged
Merged
Conversation
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
dmitrizagidulin
requested review from
PatStLouis,
isaackps,
msporny and
pohhendry
as code owners
October 6, 2026 14:23
dmitrizagidulin
requested review from
BigBlueHat,
PatStLouis,
dlongley,
iherman,
kezike and
msporny
and removed request for
PatStLouis,
isaackps,
msporny and
pohhendry
October 6, 2026 14:23
dlongley
approved these changes
Oct 6, 2026
iherman
approved these changes
Oct 7, 2026
Collaborator
Author
|
Approvals, no objections, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group consensus so far is that
payloadis a more accurate term for the entity currently termedtemplate. (In thestaticsuite, it's not a template at all but a pre-rendered payload. In thesummarysuite, it's a set of fields (also not a template). And in thehtmlsuite, it's a full HTML/JS application.)This PR renames
templatetopayload.Preview | Diff