Skip to content

Prep threat model for DNOTE publication. - #87

Merged
dmitrizagidulin merged 3 commits into
mainfrom
threat-model-dnote
Oct 13, 2026
Merged

Prep threat model for DNOTE publication.#87
dmitrizagidulin merged 3 commits into
mainfrom
threat-model-dnote

Conversation

@dmitrizagidulin

@dmitrizagidulin dmitrizagidulin commented Oct 1, 2026 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Collaborator

@dmitrizagidulin
Prep threat model for DNOTE publication.
75013b3 
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
iherman
iherman requested changes Oct 2, 2026
View reviewed changes
Comment thread threat-model/index.html Outdated
Comment thread threat-model/index.html Outdated
iherman
iherman reviewed Oct 2, 2026
View reviewed changes
Comment thread threat-model/index.html Outdated
@iherman

iherman commented Oct 2, 2026

Copy link
Copy Markdown
Member

There are a number of references to the VCDM threat model in the text, which are all wrong. They should all refer to https://www.w3.org/TR/vc-data-model-threat-model-2.1/

@iherman

iherman commented Oct 2, 2026

Copy link
Copy Markdown
Member

I have manually massaged my local copy to run a link checker, and there are issues:

Broken fragments:
https://www.w3.org/TR/vc-data-model-threat-model-2.1/#t19-tampering-with-unprotected-external-resources (line 701)
https://www.w3.org/TR/vc-data-model-threat-model-2.1/#t2-code-injection-via-credential-content (line 735)
https://www.w3.org/TR/vc-data-model-threat-model-2.1/#t10-device-tracking-and-fingerprinting (lines 780, 800)

Could you take care of those, too?

msporny
msporny reviewed Oct 2, 2026
View reviewed changes
Comment thread threat-model/index.html Outdated
msporny
msporny reviewed Oct 2, 2026
View reviewed changes
Comment thread threat-model/index.html Outdated
@dmitrizagidulin
Apply review suggestions (remove js scripts).
547a377 
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
@dmitrizagidulin
Fix links.
a1d67f1 
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
@dmitrizagidulin

dmitrizagidulin commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

I have manually massaged my local copy to run a link checker, and there are issues:

Broken fragments:
https://www.w3.org/TR/vc-data-model-threat-model-2.1/#t19-tampering-with-unprotected-external-resources (line 701)
https://www.w3.org/TR/vc-data-model-threat-model-2.1/#t2-code-injection-via-credential-content (line 735)
https://www.w3.org/TR/vc-data-model-threat-model-2.1/#t10-device-tracking-and-fingerprinting (lines 780, 800)

Could you take care of those, too?

Fixed, thanks. (I wonder why the link checker didn't flag those when I used it)

This was referenced Oct 6, 2026
Closed
Closed
@dmitrizagidulin
dmitrizagidulin merged commit 5a8516a into main Oct 13, 2026
2 checks passed
@dmitrizagidulin
dmitrizagidulin deleted the threat-model-dnote branch October 13, 2026 13:46
@dmitrizagidulin dmitrizagidulin mentioned this pull request Oct 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msporny msporny msporny left review comments
@PatStLouis PatStLouis Awaiting requested review from PatStLouis PatStLouis is a code owner
@pohhendry pohhendry Awaiting requested review from pohhendry pohhendry is a code owner
@isaackps isaackps Awaiting requested review from isaackps isaackps is a code owner
@iherman iherman Awaiting requested review from iherman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmitrizagidulin @iherman @msporny