Repository navigation
Dispatch render suites on renderSuite, not type. - #76
Conversation
9350c09 to
0035021
Compare
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
0035021 to
9d6bf9f
Compare
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
| "type": "TemplateRenderMethod", | ||
| "renderSuite": "card", | ||
| "type": "SuiteRenderMethod", | ||
| "renderSuite": "summary", |
There was a problem hiding this comment.
I don't think this is the right name, but will +1 this PR to keep things moving while we still work out a better name.
msporny
left a comment
There was a problem hiding this comment.
Approving because it's an iteration in the right direction, not because I agree with the name of the card, or think details such as "template" for NFC makes sense. I presume other PRs will follow that aligns that stuff w/ consensus of the group.
iherman
left a comment
There was a problem hiding this comment.
The section on the former card rendering is inconsistent. It uses summary in the title now, but subsections, objects, etc, are still referred to as card, and, in some examples, we are talking about data.
I am fine using the term summary for now, as part of the more general change proposed here (although the resolution on the final naming is still missing). But we should be consistent.
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
|
@iherman I updated the rest of the |
|
Several approvals, merging for momentum and to continue the discussion. |
|
I see this PR has been merged. I have not seen tracking issues for the concerns with this PR, as mentioned in #76 (comment), as "raised by @msporny, @dlongley, and/or thought of by others". Have those concerns been addressed elsewhere? |
From discussions in issues #54 and #55.
TemplateRenderMethodtoSuiteRenderMethod(keeps optional superclassRenderMethodopen, per @iherman's preferences)cardrender suite is now thesummaryrender suite.data,html,nfc(though see Foldingnfcinto astaticrender suite needs a dispatch mechanism #77) as the values this spec defines, and requires implementations to ignore entries with unrecognized values. (See issue Registry for renderSuite values #75 for related discussion)Preview | Diff