Skip to content

Handle not fully active documents when querying Permissions API - #249

Closed
marcoscaceres wants to merge 5 commits into
mainfrom
fully-active
Closed

Handle not fully active documents when querying Permissions API#249
marcoscaceres wants to merge 5 commits into
mainfrom
fully-active

Conversation

@marcoscaceres

@marcoscaceres marcoscaceres commented Jun 29, 2021

Copy link
Copy Markdown
Member

closes #162

The following tasks have been completed:

  • Modified Web platform tests (link)

Implementation commitment:

CC @johannhof


Preview | Diff

@marcoscaceres
marcoscaceres requested review from annevk and jan-ivar June 29, 2021 05:54
@marcoscaceres

Copy link
Copy Markdown
Member Author

Filed gecko bug and sent patch.

@johannhof

Copy link
Copy Markdown
Member

This seems fine by me by intent though @annevk or so should probably review the spec language :)

@marcoscaceres

Copy link
Copy Markdown
Member Author

@rakina @reillyeon, here is another "not fully active" change 😇 ... I'm wondering if we could coordinate on it?

I have a patch ready to land in Gecko, but need support from a second implementer before landing it both here and in Gecko.

@rakina

rakina commented Jul 14, 2021

Copy link
Copy Markdown
Member

Thanks for doing this! I'm not really familiar with Permissions API, but I'm a bit concerned about not updating the document when it becomes fully active again in this case (Unlike the Geolocation updates in the other PR which seems a bit more OK to drop/leave the document at a stale status), so I've posted in the original issue: #162 (comment)

@rakina

rakina commented Aug 11, 2021

Copy link
Copy Markdown
Member

Thanks! This looks reasonable, and I've filed a Chrome bug for this: https://bugs.chromium.org/p/chromium/issues/detail?id=1238709

@marcoscaceres

Copy link
Copy Markdown
Member Author

Thanks @rakina. I'll put together a WTP for this in the meantime.

@marcoscaceres

Copy link
Copy Markdown
Member Author

Moved to #365

@marcoscaceres
marcoscaceres deleted the fully-active branch February 21, 2022 04:43
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 21, 2022
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 21, 2022
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Feb 21, 2022
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Feb 22, 2022
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle non-fully-active documents

3 participants