Fix ReSpec build and Pages publishing - #583
Draft
korrayt wants to merge 1 commit into
Draft
Conversation
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - run: | |
Collaborator
There was a problem hiding this comment.
Currently all development is in main branch but we need to put the built documents on to gh-pages
If I'm reading this diff correctly you are making gh-pages the source branch? I'm not sure we want to change that at this time (although I can believe this step has issues, it has basically been working for some years?)
or are you saying spec-prod can handle that on its own now, I should check....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mathml-polyfillsso the ReSpec build can load_MathTransforms.mathpresentation example as source-only markup instead of wrapping it in another generated outermathelement.w3c/spec-prodmanage thegh-pagesbranch after a successful build, and correct the W3C decision URL typo.Root cause
The latest CI build imports
_MathTransformsas a named export, whileall-polyfills.jsexposes it as the default export. Theshowcorepost-processing hook also wraps MathML examples in an outermathelement; that made the nested-mathexample produce invalid generated markup. The workflow resetgh-pagesbefore the build, so a failed build could leave the Pages branch without the generated document.Validation
mathelements.git diff --checkpassed.Related to #522.