Implement Unicode composition/decomposition codepoint closure.#228
Merged
Conversation
Allow bazel runfile resolution to be swapped out for fixed paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unicode composition and decomposition to both the dependency graph and glyph closure during segmentation.
Text shapers may choose to apply unicode composition and decomposition to text prior to shaping. As a result the computed glyph dependencies used by the segmenter must take into account any unicode composition and decomposition substitutions that may happen. For context, the problem is explained in more detail here:
ift-encoder/ift/config/segmenter_config.proto
Line 262 in 52d3e9d
UCD data files are used to construct a unicode to unicode dependency graph for both composition and decomposition. This is added to DependencyGraph which then incorporates it into condition analysis. Likewise the glyph closure computation is modified to added unicode closure via the dependency graph as a pre-step before handing off to harfbuzz.
This should unblock the use of patch merging which is currently disabled. That will be explored in a following PR.