Reduce impact of brotli compression size noise on init font merging.#225
Merged
Conversation
In dep graph only mode inert segments weren't being computed since that was previously done only in SegmentationContext::ReprocessSegment() which isn't used in the dep graph only pathway.
…ticular set of glyphs. I've noticed a cases of good merges to the init font being passed up due to noise in brotli compressed sizes (eg. the size delta for the same glyphs will vary signficantly against different base glyphs, particularily seeing larger increases somewhat randomly). This adds a cache of the lowest seen size increase and uses that instead of the value computed per iteration. In general the rough expectation is that size increase for a set of glyphs roughly decreases as the the base size increases due to more opportunities for data sharing.
When not running in DEP_GRAPH_ONLY, it's possible for a patch to become empty due to exclusive gids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed a cases of good merges to the init font being passed up due to noise in brotli compressed sizes (the size delta for the same glyphs will vary signficantly against different base glyphs, particularily seeing larger increases somewhat randomly). This adds a cache of the lowest seen size increase and uses that instead of the value computed per iteration. In general the rough expectation is that size increase for a set of glyphs roughly decreases as the the base size increases due to more opportunities for data sharing.
Also fixes missing inert segment calculation when in dep graph only mode.