Reduce segmenter memory usage further.#223
Merged
Merged
Conversation
Contributor
garretrieger
commented
May 13, 2026
garretrieger
commented
- Only store pair probabilities for codepoints that are in the font being processed. Pairs that are not a subset of the input font will not ever be needed.
- Add periodic reset to the bigram -> probability cache to clear out entries that are no longer needed.
Will reduce memory consumed by frequency data by keeping only what's relevant to the segmenting operation.
Without reset it's memory usage grows unbounded and can be significant for longer segmenter runs. This resets the cache after each base segment is finished. The probability calculations are fairly scoped to the current base segment so this has minimal impact on observed cache hit rates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.