Skip to content

T8966: add legacy-label escape to invalid-task-id rule (commit check exempt)#42

Merged
andamasov merged 1 commit into
rollingfrom
feat/T8966-legacy-escape
Jun 7, 2026
Merged

T8966: add legacy-label escape to invalid-task-id rule (commit check exempt)#42
andamasov merged 1 commit into
rollingfrom
feat/T8966-legacy-escape

Conversation

@andamasov
Copy link
Copy Markdown
Member

Adds a maintainer-controlled legacy label escape to the per-repo T-ID rule (toggles invalid-task-id). The PR title check stays enforced for every PR; the per-commit check is exempted when a PR carries the legacy label — an escape hatch for grandfathered PRs whose commit history cannot be rewritten (repos that squash-merge and block force-push). Pilot verified on vyos/vyos.vyos. Change-management: IS-539. Tracked under T8966.

🤖 Generated by robots

@andamasov andamasov merged commit 4fb0250 into rolling Jun 7, 2026
0 of 3 checks passed
@andamasov andamasov deleted the feat/T8966-legacy-escape branch June 7, 2026 22:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 7, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ae35e2f1-3657-4e3b-aeea-4be1ab815c2e

📥 Commits

Reviewing files that changed from the base of the PR and between 966bab9 and 70a1a99.

📒 Files selected for processing (1)
  • .github/mergify.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated internal pull request validation automation to exclude legacy pull requests from commit message formatting checks.

Walkthrough

The PR modifies the Mergify automation rule in .github/mergify.yml to gate the T<digits>: task-ID commit-message validation. When a PR is labeled legacy, the commit-message regex check is bypassed. The validation pattern itself remains unchanged; only the conditional trigger is updated.

Changes

Mergify Commit-Message Rule Gating

Layer / File(s) Summary
Commit-message validation gating by label
.github/mergify.yml
Lines 40–42: An and block adds label!=legacy condition to gate the existing task-ID commit-message regex check, allowing legacy-labeled PRs to skip this validation.

Possibly related PRs

  • vyos/vyatta-bash#39: Adds or modifies T<digits>: title/commit check gating via labels in the same Mergify rules.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/T8966-legacy-escape

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the rolling label Jun 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2026

👍
No issues in PR Title / Commit Title

@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed This PR has been mirrored successfully and removed mirror-initiated This PR initiated for mirror sync workflow labels Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mirror-completed This PR has been mirrored successfully rolling

Development

Successfully merging this pull request may close these issues.

1 participant