Repository navigation
docs: DESIGN, CONTRIBUTING and RELEASING catch up with the code - #558
Merged
Merged
Conversation
- DESIGN §4: two character sets are translated, DEC Special Graphics and the UK set, not one, and DECSC/DECRC save and restore the charset state; LS2/LS3 are still not modelled. The charset and tab-stop scopes are listed in docs/LIMITATIONS.md, not the README, which has neither (#535). - DESIGN §5: env_clear() also pins SHELL=/bin/sh unless the test sets it, and why (#221) (#536). - CONTRIBUTING §2: a bullet for tools/, preflight.sh and the gate self-tests (#537). - RELEASING step 1: the two copies of the version no gate checks, the bug report form's placeholder and SKILL.md's "Written against" line. The placeholder stayed at 0.5.0 through eleven releases, 0.6.0 to 0.11.1, not the six the issue said; checked against git history (#540). From the same review, verified before changing: - ci.yml: the "single stable job name for branch protection" comment sat above the skill job; it is back above required-green. Comment-only. - The emit fixture's rule listed every timer but the 10 ms poll --idle waits for SIGTERM with. - LIMITATIONS.md: "modeled" beside five "modelled" in the same file, and "behavior" where the rest of the docs write "behaviour". Closes #535 Closes #536 Closes #537 Closes #540 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
vyncint
force-pushed
the
docs/design-contributing-releasing-0.11.5
branch
from
October 6, 2026 23:35
02dbe88 to
a756fec
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the UK set, not one, and DECSC/DECRC save and restore the charset state;
LS2/LS3 are still not modelled. The charset and tab-stop scopes are
listed in docs/LIMITATIONS.md, not the README, which has neither (docs: DESIGN §4 says one character set is translated and DECSC does not save charset state; both are stale #535).
and why (
env_clear()still hands the child aSHELL, and it is the machine's rather than the caller's #221) (docs: DESIGN §5 describes TERM and env_clear but not the SHELL=/bin/sh default #536).self-tests (docs: CONTRIBUTING §2's project layout does not mention tools/ #537).
bug report form's placeholder and SKILL.md's "Written against" line. The
placeholder stayed at 0.5.0 through eleven releases, 0.6.0 to 0.11.1,
not the six the issue said; checked against git history (docs: RELEASING step 1 does not list the bug report form's version placeholder #540).
From the same review, verified before changing:
above the skill job; it is back above required-green. Comment-only.
waits for SIGTERM with.
"behavior" where the rest of the docs write "behaviour".
Closes #535
Closes #536
Closes #537
Closes #540