backend: trust local state on LWS server switch#9
Draft
plowsof wants to merge 1 commit into
Draft
Conversation
switching LWS servers preserves the tx history and balance and only scans blocks the wallet hasn't seen
plowsof
force-pushed
the
resume-sync-trust-local
branch
from
2c76867 to
2562e76
Compare
Author
|
feedback from sgp vtnerd ofrnxmr blocks this reg re-orgs:
Proper:
|
vtnerd
reviewed
Jun 27, 2026
Owner
There was a problem hiding this comment.
This doesn't work well with reorgs (as commented on in Matrix). You can arbitrarily set the height lower, but if the reorg goes past that point, the same issue occurs. The only way to fix this is to change the protocol to include a hash, to ensure that wallet is always on the correct chain. I'm not sure it's worth the change, despite this being a reasonable usability change.
EDIT: Sorry I missed your follow-up before posting this. I'm not sure we want to change the protocol for this, but perhaps it can be added without too much hassle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switching LWS servers preserves the tx history and balance and only scans blocks the wallet hasn't seen