Skip to content

fix: add missing typings for list context provider#15

Open
gab1618 wants to merge 1 commit into
vtex-apps:masterfrom
gab1618:fix/typing
Open

fix: add missing typings for list context provider#15
gab1618 wants to merge 1 commit into
vtex-apps:masterfrom
gab1618:fix/typing

Conversation

@gab1618

@gab1618 gab1618 commented Jun 10, 2026

Copy link
Copy Markdown

What problem is this solving?

It adds a missing property that the list context provider accepts, but is not declared on the typings.

I tried to use the ListContextProvider component in another Vtex React app, but I couldn't properly use it, due to the typings being incomplete:

image

In the end, I had to come up with this nasty solution that declares a wrapper and forces any typings into everything, which is far from ideal.

image

How to test it?

Just check if the typings are fine, since I didn't make any change other than the typings.

Screenshots or example usage:

I won't have any, since this is not a visual thing

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

🗿

![](put .gif link here - can be found under "advanced" on giphy)

The current typing only indicates that this component receives the `list` prop, when it should receive the children prop as well
@gab1618 gab1618 requested a review from a team as a code owner June 10, 2026 20:46
@gab1618 gab1618 requested review from gabpaladino, mendescamara and vsseixaso and removed request for a team June 10, 2026 20:46
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Jun 10, 2026

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

Copy link
Copy Markdown

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@gab1618

gab1618 commented Jun 11, 2026

Copy link
Copy Markdown
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant