fix: add missing typings for list context provider#15
Open
gab1618 wants to merge 1 commit into
Open
Conversation
The current typing only indicates that this component receives the `list` prop, when it should receive the children prop as well
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
It adds a missing property that the list context provider accepts, but is not declared on the typings.
I tried to use the ListContextProvider component in another Vtex React app, but I couldn't properly use it, due to the typings being incomplete:
In the end, I had to come up with this nasty solution that declares a wrapper and forces
anytypings into everything, which is far from ideal.How to test it?
Just check if the typings are fine, since I didn't make any change other than the typings.
Screenshots or example usage:
I won't have any, since this is not a visual thing
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
🗿
