Skip to content

Fix EventHub listener disposal - #53

Merged
vrtmrz merged 1 commit into
mainfrom
fix/eventhub-listener-lifecycle
Sep 4, 2026
Merged

vrtmrz merged 1 commit into
mainfrom
fix/eventhub-listener-lifecycle

Conversation

@vrtmrz

@vrtmrz vrtmrz commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Fix EventHub subscription lifecycle handling so caller-provided abort signals and returned disposers affect only their own registration.

Summary

  • Honour caller-supplied abort signals in on and onEvent.
  • Make returned disposers registration-scoped and idempotent.
  • Prevent stale disposers from removing later subscriptions using the same callback.
  • Accept AddEventListenerOptions in once and onceEvent.
  • Preserve off(event, callback) as a bulk-removal compatibility API.
  • Update generated output, API documentation, and release notes.

Verification

  • Confirmed seven focused regression cases failed against the previous implementation.
  • EventHub tests: 30 passed.
  • Octagonal Wheels browser tests: 983 passed.
  • Octagonal Wheels Node tests: 4 passed.
  • ESLint and TypeScript checks passed.
  • Package build, dry-run pack, and built-artefact runtime probe passed.

@vrtmrz
vrtmrz merged commit 8fa7957 into main Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant