Repository navigation
Edit: Fix JavaScript error with a nullable boolean column - #1364
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the edit form of a row with a nullable
booleancolumn throws on load, before anything is clicked:To reproduce on PostgreSQL:
Open
?pgsql=…&edit=t&where[id]=1and look at the console. New item throws too.input()renders a boolean as<input type='hidden'>plus<input type='checkbox'>, both namedfields[b], and the column being nullable gives it a function select, whose initialfire(…, 'change')runsfunctionChange(). There,this.form['fields[b]']is aRadioNodeList, which has noclassList, andalterClass()only guards against null. ANOT NULLboolean has no function select, so it doesn't throw.The fix takes the checkbox out of the
RadioNodeList. The test inpgsql.spec.jsopens the edit form of the existingtypestable (itso booleanis nullable) and fails without the fix throughexpectNoErrors().