Skip to content

Allow options in objectToDocumentXML when calling a method #1096

Open
ndeniche wants to merge 1 commit into
vpulim:masterfrom
ndeniche:ndeniche_override-base-element
Open

Allow options in objectToDocumentXML when calling a method #1096
ndeniche wants to merge 1 commit into
vpulim:masterfrom
ndeniche:ndeniche_override-base-element

Conversation

@ndeniche

@ndeniche ndeniche commented Nov 8, 2019

Copy link
Copy Markdown

Allows overriding the InputMessage "Request" element for custom elements based on args param

  • Options is optional field for objectToDocumentXML function
  • Replicates _xml parameter functionality (sending a custom XML structure as a literal) with JSON arguments.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.5%) to 94.529% when pulling 130c204 on ndeniche:ndeniche_override-base-element into af93a6f on vpulim:master.

@jsdevel

jsdevel commented Nov 8, 2019

Copy link
Copy Markdown
Collaborator

@ndeniche please add more tests to cover all scenarios.

@jsdevel

jsdevel commented Nov 14, 2019

Copy link
Copy Markdown
Collaborator

i'm closing this in 4 days if there's no more action

@ndeniche

Copy link
Copy Markdown
Author

All of my new code is covered. Should I improve coverage by adding tests to other features?

@jsdevel

jsdevel commented Nov 18, 2019

Copy link
Copy Markdown
Collaborator

@ndeniche if coverage has decreased, then not all the added code has been covered.

@smokhov

smokhov commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

@w666 -- can the current, up-to-date, checks be re-ran on this since coveralls was removed?

@w666

w666 commented Jan 14, 2025

Copy link
Copy Markdown
Collaborator

@smokhov I don't have access to coveralls, project was not properly maintained for some time.
Do you need this feature? I can have a look on this, just too much stuff happening at the moment, but I can allocate some time if needed. Thanks.

@smokhov

smokhov commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

@w666 I don't think coveralls is needed, just force-run the current tests from github actions. It's not at all urgent; just helping to clean out stale PRs, hopefully. Their other PR #1095 seems like was more needed back then.

@w666 w666 force-pushed the ndeniche_override-base-element branch 2 times, most recently from f261f01 to cb1de16 Compare March 19, 2025 06:46
@w666

w666 commented Mar 19, 2025

Copy link
Copy Markdown
Collaborator

Okay, rebased that one, it works. I will have another look before next release. Thanks for help.

* Options is optional field for objectToDocumentXML function
* Replicates `_xml` parameter functionality (sending a custom XML structure as a literal) with JSON arguments.
@w666 w666 force-pushed the ndeniche_override-base-element branch from cb1de16 to 3a38e86 Compare April 22, 2025 07:23
@w666

w666 commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

Nah, can't approve this, test does not work, test still pass even when I set overrideBaseElement: false or do not set it at all.

PR goes to backlog for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants