Skip to content

Moving to C++20#857

Merged
mezpusz merged 4 commits into
masterfrom
c++20
May 22, 2026
Merged

Moving to C++20#857
mezpusz merged 4 commits into
masterfrom
c++20

Conversation

@mezpusz

@mezpusz mezpusz commented May 19, 2026

Copy link
Copy Markdown
Contributor

Compiled on my Mac and our Linux cluster, please try on your own machines too. There was some warning only on Linux and release referring to "array out of bounds" in one of the uses of Allocator.

I can regression test it also if all else looks good.

@quickbeam123

Copy link
Copy Markdown
Collaborator

My Makefile paths are happy, both on Mac and Linux.

(With MacOs 26, it seems gcc is becoming less and less supported, so I am explicitly using clang there.)

@MichaelRawson MichaelRawson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK here (Debian trixie, Clang 19) - thanks for doing the work upstream in VIRAS as well.

I didn't get any warnings about Allocator - what do you get? I am perpetually suspicious of that thing, even after cutting it back.

@mezpusz

mezpusz commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

c++20-allocator-warnings.txt

These are all warnings (maybe overlapping), rooted in ExtensionalityResolution as far as I can see. The strange thing is that they only appear in release mode. My clang version is Debian clang version 19.1.7 (3+b1). Let me know if you make something out of this.

@MichaelRawson

Copy link
Copy Markdown
Contributor

Weird, I have the exact same version of clang, but no warning in release mode. The error also seems weird, it's like the compiler hallucinates some type information somewhere - unsigned char [4] is the wrong type for SmartPtr::RefCounter and the error would be wrong even if it were. Let's merge and see if it persists somehow?

@mezpusz mezpusz merged commit eef6af7 into master May 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants