Skip to content

Add sum oracle to the fuzzer and reject samples that have order dependent overflow behaviour - #9801

Open
robert3005 wants to merge 5 commits into
developfrom
rk/sumfuzzoracle
Open

Add sum oracle to the fuzzer and reject samples that have order dependent overflow behaviour#9801
robert3005 wants to merge 5 commits into
developfrom
rk/sumfuzzoracle

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Fuzzer sum oracle does chunk by chunk aggregation instead of canonicalising and
running aggregate on single chunk

@robert3005 robert3005 added the changelog/chore A trivial change label Sep 8, 2026
@codspeed-hq

codspeed-hq Bot commented Sep 8, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 2190 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime mul_u32_nonnull_avx512 5.5 µs 6.2 µs -10.24%
Simulation decompress[u64, (4000, 1024)] 86.1 µs 70.8 µs +21.62%
WallTime arrow_checked_add_u32_avx2[16384] 21.4 µs 17.7 µs +21.12%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/sumfuzzoracle (eff1c5b) with develop (2a5b1a7)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 enabled auto-merge (squash) September 9, 2026 15:21
@robert3005 robert3005 changed the title Add sum oracle to the fuzzer Add sum oracle to the fuzzer and reject samples that have order dependent overflow behaviour Sep 9, 2026
Comment thread fuzz/src/array/sum/mod.rs
}
}

fn accumulate<T>(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment. But I think you want to filter >0 and <0 and sum each and it will read better

Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants