Skip to content

Test IO file sizes in Rust and array sizes in Python doctests - #9792

Open
robert3005 wants to merge 2 commits into
developfrom
rk/python-io-doctest-size
Open

Test IO file sizes in Rust and array sizes in Python doctests#9792
robert3005 wants to merge 2 commits into
developfrom
rk/python-io-doctest-size

Conversation

@robert3005

@robert3005 robert3005 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Python io doc tests check compressed size in bytes since that's what they're talking about. Keep the file size test as a rust test

@robert3005
robert3005 force-pushed the rk/python-io-doctest-size branch from e1cf626 to 8bb4130 Compare September 8, 2026 11:13
@codspeed-hq

codspeed-hq Bot commented Sep 8, 2026

Copy link
Copy Markdown

Merging this PR will regress 2 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 2 regressed benchmarks
✅ 2195 untouched benchmarks
⏩ 206 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime words_gather_scalar_avx2[65536] 8.2 µs 9.4 µs -12.02%
Simulation allocate_drop_arrow[0] 402.7 ns 456.9 ns -11.86%
WallTime arrow_checked_add_u32_neon[16384] 20.3 µs 13.3 µs +52.31%
WallTime arrow_checked_add_u32_avx512[16384] 21.3 µs 17.6 µs +21.23%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/python-io-doctest-size (e8208a8) with develop (898b59f)

Open in CodSpeed

Footnotes

  1. 206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 added changelog/docs A docs change changelog/chore A trivial change and removed changelog/docs A docs change labels Sep 8, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 force-pushed the rk/python-io-doctest-size branch from 8bb4130 to d6147dd Compare September 8, 2026 11:23

@joseph-isaacs joseph-isaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this into a rust test on the written file size. It really useful to know when we change file size

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 changed the title Python io doctests assert on nbytes not on the file size Test IO file sizes in Rust and array sizes in Python doctests Sep 8, 2026
@robert3005

Copy link
Copy Markdown
Contributor Author

Here you go, there's a rust test now, I kept the python change since this is useful for docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants