Test IO file sizes in Rust and array sizes in Python doctests - #9792
Test IO file sizes in Rust and array sizes in Python doctests#9792robert3005 wants to merge 2 commits into
Conversation
e1cf626 to
8bb4130
Compare
Merging this PR will regress 2 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | words_gather_scalar_avx2[65536] |
8.2 µs | 9.4 µs | -12.02% |
| ❌ | Simulation | allocate_drop_arrow[0] |
402.7 ns | 456.9 ns | -11.86% |
| ⚡ | WallTime | arrow_checked_add_u32_neon[16384] |
20.3 µs | 13.3 µs | +52.31% |
| ⚡ | WallTime | arrow_checked_add_u32_avx512[16384] |
21.3 µs | 17.6 µs | +21.23% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/python-io-doctest-size (e8208a8) with develop (898b59f)
Footnotes
-
206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Robert Kruszewski <github@robertk.io>
8bb4130 to
d6147dd
Compare
joseph-isaacs
left a comment
There was a problem hiding this comment.
Can we move this into a rust test on the written file size. It really useful to know when we change file size
Signed-off-by: Robert Kruszewski <github@robertk.io>
|
Here you go, there's a rust test now, I kept the python change since this is useful for docs |
Python io doc tests check compressed size in bytes since that's what they're talking about. Keep the file size test as a rust test