Skip to content

ci(bench): drop Clickbench Sorted from the "pr" SQL benchmark preset - #9784

Draft
joseph-isaacs wants to merge 1 commit into
developfrom
claude/disable-clickbench-sorted-precommit-ke7orh
Draft

ci(bench): drop Clickbench Sorted from the "pr" SQL benchmark preset#9784
joseph-isaacs wants to merge 1 commit into
developfrom
claude/disable-clickbench-sorted-precommit-ke7orh

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

Summary

Stop running the Clickbench Sorted on NVME benchmark as part of the default pull-request SQL benchmark matrix (the pr preset, triggered by the action/bench-sql label).

Changes

  • bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py: remove the pr entry from the clickbench-sorted-nvme case. It still runs under pr-compact, pr-all, pr-full, and develop. Because pr-all is defined as the union of pr and pr-compact, its coverage for this case narrows from STANDARD to COMPACT (the same pattern tpch-s3-10 and appian-nvme already use).
  • bench-orchestrator/tests/test_matrix.py: update the expected pr preset IDs.

Resolved pr matrix after this change:
clickbench-nvme, tpch-nvme, tpch-s3, tpch-nvme-10, tpcds-nvme, statpopgen, fineweb, fineweb-s3, polarsignals

Checks run locally:

  • uv run --project bench-orchestrator --with pytest python -m pytest tests/test_matrix.py (12 passed)
  • ruff check and ruff format --check on the two changed files
  • vx-bench matrix pr / vx-bench matrix pr-all to confirm the rendered output

🤖 Generated with Claude Code

https://claude.ai/code/session_01C9e8MM2rjbnH4qN4jtzMKm


Generated by Claude Code

The sorted ClickBench variant no longer runs in the default pull-request
SQL benchmark matrix (the `action/bench-sql` label). It still runs under
`pr-compact`, `pr-all`, `pr-full`, and `develop`. Since `pr-all` is the
union of `pr` and `pr-compact`, its coverage for this case narrows to
the compact targets.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C9e8MM2rjbnH4qN4jtzMKm
@codspeed-hq

codspeed-hq Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merging this PR will regress 4 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 4 regressed benchmarks
✅ 2191 untouched benchmarks
⏩ 206 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation random_i8[0.5] 67.3 µs 91.4 µs -26.35%
Simulation decompress[u64, (4000, 1024)] 70.4 µs 85.5 µs -17.69%
WallTime words_gather_scalar_avx2[65536] 8.3 µs 9.4 µs -11.72%
Simulation allocate_drop_bytes[0] 466 ns 520.2 ns -10.41%
WallTime arrow_checked_add_u32_neon[16384] 20.5 µs 12.8 µs +60.82%
Simulation random_i8[0.8] 99.2 µs 69.9 µs +41.99%
WallTime filtered_owned_i64_neon[NineNullsInTen] 29 µs 26.1 µs +11.38%
WallTime filtered_sink_i64_neon[NineNullsInTen] 28.8 µs 25.8 µs +11.36%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/disable-clickbench-sorted-precommit-ke7orh (f6a2971) with develop (dc1b355)

Open in CodSpeed

Footnotes

  1. 206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

"pr": DEFAULT,
"pr-compact": COMPACT,
"pr-all": STANDARD,
"pr-all": COMPACT,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be still standard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants