ci(bench): drop Clickbench Sorted from the "pr" SQL benchmark preset - #9784
ci(bench): drop Clickbench Sorted from the "pr" SQL benchmark preset#9784joseph-isaacs wants to merge 1 commit into
Conversation
The sorted ClickBench variant no longer runs in the default pull-request SQL benchmark matrix (the `action/bench-sql` label). It still runs under `pr-compact`, `pr-all`, `pr-full`, and `develop`. Since `pr-all` is the union of `pr` and `pr-compact`, its coverage for this case narrows to the compact targets. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C9e8MM2rjbnH4qN4jtzMKm
Merging this PR will regress 4 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | random_i8[0.5] |
67.3 µs | 91.4 µs | -26.35% |
| ❌ | Simulation | decompress[u64, (4000, 1024)] |
70.4 µs | 85.5 µs | -17.69% |
| ❌ | WallTime | words_gather_scalar_avx2[65536] |
8.3 µs | 9.4 µs | -11.72% |
| ❌ | Simulation | allocate_drop_bytes[0] |
466 ns | 520.2 ns | -10.41% |
| ⚡ | WallTime | arrow_checked_add_u32_neon[16384] |
20.5 µs | 12.8 µs | +60.82% |
| ⚡ | Simulation | random_i8[0.8] |
99.2 µs | 69.9 µs | +41.99% |
| ⚡ | WallTime | filtered_owned_i64_neon[NineNullsInTen] |
29 µs | 26.1 µs | +11.38% |
| ⚡ | WallTime | filtered_sink_i64_neon[NineNullsInTen] |
28.8 µs | 25.8 µs | +11.36% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/disable-clickbench-sorted-precommit-ke7orh (f6a2971) with develop (dc1b355)
Footnotes
-
206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
| "pr": DEFAULT, | ||
| "pr-compact": COMPACT, | ||
| "pr-all": STANDARD, | ||
| "pr-all": COMPACT, |
There was a problem hiding this comment.
this should be still standard?
Summary
Stop running the
Clickbench Sorted on NVMEbenchmark as part of the default pull-request SQL benchmark matrix (theprpreset, triggered by theaction/bench-sqllabel).Changes
bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py: remove theprentry from theclickbench-sorted-nvmecase. It still runs underpr-compact,pr-all,pr-full, anddevelop. Becausepr-allis defined as the union ofprandpr-compact, its coverage for this case narrows fromSTANDARDtoCOMPACT(the same patterntpch-s3-10andappian-nvmealready use).bench-orchestrator/tests/test_matrix.py: update the expectedprpreset IDs.Resolved
prmatrix after this change:clickbench-nvme, tpch-nvme, tpch-s3, tpch-nvme-10, tpcds-nvme, statpopgen, fineweb, fineweb-s3, polarsignalsChecks run locally:
uv run --project bench-orchestrator --with pytest python -m pytest tests/test_matrix.py(12 passed)ruff checkandruff format --checkon the two changed filesvx-bench matrix pr/vx-bench matrix pr-allto confirm the rendered output🤖 Generated with Claude Code
https://claude.ai/code/session_01C9e8MM2rjbnH4qN4jtzMKm
Generated by Claude Code