Skip to content

feat(cache): name the changed env var in cache-miss message#438

Merged
wan9chi merged 1 commit into
mainfrom
codex/cache-env-miss-name
Jun 11, 2026
Merged

feat(cache): name the changed env var in cache-miss message#438
wan9chi merged 1 commit into
mainfrom
codex/cache-env-miss-name

Conversation

@wan9chi

@wan9chi wan9chi commented Jun 11, 2026

Copy link
Copy Markdown
Member

Motivation

The task runner already detects which fingerprinted env vars changed between cache entries, but the inline cache-miss status collapsed that detail to envs changed. That made the live output less useful than the persisted detailed summary.

Changes

  • Add EnvMismatch::name() so cache display code can reuse the detected env var name.
  • Render inline env cache misses as env 'NAME' changed or envs 'A', 'B' changed.
  • Update the cache-miss snapshots that exercise env additions, removals, value changes, and per-env cache keys.
  • Add the changelog entry for feat(cache): name the changed env var in cache-miss message #438.

Verification

  • cargo test -p vite_task_bin --test e2e_snapshots cache_miss_reasons
  • cargo test -p vite_task_bin --test e2e_snapshots individual_cache_for_env
  • cargo fmt
  • cargo check --all-features
  • cargo clippy --all-features -- -D warnings
  • cargo test

wan9chi commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

The inline cache-miss reason now names the env var(s) that changed -- `env 'NODE_ENV' changed` (or `envs 'A', 'B' changed` for several) instead of a bare `envs changed`. The detailed summary already named the vars; this brings the compact live status in line with it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@wan9chi wan9chi force-pushed the codex/cache-env-miss-name branch from 39216f3 to ca6fb41 Compare June 11, 2026 15:23
@wan9chi wan9chi marked this pull request as ready for review June 11, 2026 15:28
@wan9chi wan9chi merged commit 3259649 into main Jun 11, 2026
15 checks passed
@wan9chi wan9chi deleted the codex/cache-env-miss-name branch June 11, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant