Skip to content

chore: enable e18e lint rules - #3088

Open
fengmk2 wants to merge 1 commit into
mainfrom
chore/e18e-lint
Open

fengmk2 wants to merge 1 commit into
mainfrom
chore/e18e-lint

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 16, 2026

Copy link
Copy Markdown
Member

Enable the recommended @e18e/eslint-plugin rules through vp lint and vp check to catch additional modernization and performance issues. Update existing code to satisfy the enabled rules.

Keep e18e/prefer-spread-syntax disabled because its automatic fix can change array concatenation behavior under Oxlint. Keep e18e/prefer-static-regex disabled to preserve local regular expressions. Allow the existing cross-spawn and glob imports.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: b0b3918

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://chore-e18e-lint-viteplus-dev.voidzero-docs.workers.dev (commit b0b3918)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://6d8444f2-viteplus-dev.voidzero-docs.workers.dev b0b3918 2026-10-16T14:56:41.029Z Visit the dashboard ↗

@github-actions

Copy link
Copy Markdown
Contributor

CLI artifact sizes (b0b3918)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.20 MiB 2.20 MiB -129 B (-0.01%)
packages/core/dist Directory total 4.08 MiB 4.08 MiB 0 B (0.00%)
Combined package dist Directory total 6.28 MiB 6.28 MiB -129 B (-0.00%)
vp (Linux x64) Binary 10.21 MiB 10.21 MiB 0 B (0.00%)
vp (Linux x64) gzip -9 4.50 MiB 4.50 MiB 0 B (0.00%)
NAPI (Linux x64) Binary 34.53 MiB 34.53 MiB 0 B (0.00%)
NAPI (Linux x64) gzip -9 13.81 MiB 13.81 MiB 0 B (0.00%)
vp (macOS ARM64) Binary 7.62 MiB 7.62 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 3.94 MiB 3.94 MiB 0 B (0.00%)
NAPI (macOS ARM64) Binary 41.52 MiB 41.52 MiB 0 B (0.00%)
NAPI (macOS ARM64) gzip -9 17.97 MiB 17.97 MiB 0 B (0.00%)
vp (Windows x64) Binary 8.29 MiB 8.29 MiB 0 B (0.00%)
vp (Windows x64) gzip -9 3.66 MiB 3.66 MiB +1 B (+0.00%)
NAPI (Windows x64) Binary 30.60 MiB 30.60 MiB 0 B (0.00%)
NAPI (Windows x64) gzip -9 12.51 MiB 12.51 MiB +5 B (+0.00%)
Trampoline (Windows x64) Binary 13.50 KiB 13.50 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.09 KiB 7.09 KiB 0 B (0.00%)
Installer (Windows x64) Binary 3.63 MiB 3.63 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 1.78 MiB 1.78 MiB +2 B (+0.00%)

@fengmk2
fengmk2 marked this pull request as ready for review October 17, 2026 03:04
@fengmk2 fengmk2 self-assigned this Oct 17, 2026
@fengmk2
fengmk2 requested review from cpojer and wan9chi October 17, 2026 03:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant