Skip to content

fix(env): preserve PowerShell argument separators - #3083

Draft
fengmk2 wants to merge 1 commit into
mainfrom
codex/fix-powershell-argument-separator
Draft

fengmk2 wants to merge 1 commit into
mainfrom
codex/fix-powershell-argument-separator

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 16, 2026

Copy link
Copy Markdown
Member

PowerShell consumes a bare -- when invoking the vp.ps1 wrapper, so vp create vite -- --template react-ts rejects --template instead of forwarding it to create-vite.

Restore the separator at its original argument position using the caller's command AST, without re-evaluating argument expressions. Preserve quoted and escaped separators, array splatting, and the existing environment-switching and exit-status behavior on PowerShell 7 and Windows PowerShell 5.1.

Fixes #3080.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://codex-fix-powershell-argument-separator-viteplus-dev.voidzero-docs.workers.dev (commit 3851fba)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://9bd15b37-viteplus-dev.voidzero-docs.workers.dev 3851fba 2026-10-16T04:57:25.814Z Visit the dashboard ↗

@github-actions

Copy link
Copy Markdown
Contributor

CLI artifact sizes (3851fba)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.20 MiB 2.20 MiB 0 B (0.00%)
packages/core/dist Directory total 4.08 MiB 4.08 MiB 0 B (0.00%)
Combined package dist Directory total 6.28 MiB 6.28 MiB 0 B (0.00%)
vp (Linux x64) Binary 10.21 MiB 10.22 MiB +4.00 KiB (+0.04%)
vp (Linux x64) gzip -9 4.50 MiB 4.50 MiB +822 B (+0.02%)
NAPI (Linux x64) Binary 34.53 MiB 34.53 MiB 0 B (0.00%)
NAPI (Linux x64) gzip -9 13.81 MiB 13.81 MiB 0 B (0.00%)
vp (macOS ARM64) Binary 7.62 MiB 7.62 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 3.94 MiB 3.94 MiB +648 B (+0.02%)
NAPI (macOS ARM64) Binary 41.52 MiB 41.52 MiB 0 B (0.00%)
NAPI (macOS ARM64) gzip -9 17.98 MiB 17.98 MiB 0 B (0.00%)
vp (Windows x64) Binary 8.29 MiB 8.29 MiB +2.50 KiB (+0.03%)
vp (Windows x64) gzip -9 3.66 MiB 3.66 MiB +850 B (+0.02%)
NAPI (Windows x64) Binary 30.60 MiB 30.60 MiB 0 B (0.00%)
NAPI (Windows x64) gzip -9 12.51 MiB 12.51 MiB -3 B (-0.00%)
Trampoline (Windows x64) Binary 13.50 KiB 13.50 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.09 KiB 7.09 KiB 0 B (0.00%)
Installer (Windows x64) Binary 3.63 MiB 3.63 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 1.78 MiB 1.78 MiB 0 B (0.00%)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PowerShell 7 fails to create a project when using the command vp create vite -- --template react-ts

1 participant