Skip to content

test: allow time for the Playwright type check on slow runners - #3082

Merged
fengmk2 merged 2 commits into
mainfrom
test/exports-map-playwright-timeout
Oct 17, 2026
Merged

fengmk2 merged 2 commits into
mainfrom
test/exports-map-playwright-timeout

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 16, 2026

Copy link
Copy Markdown
Member

checks Playwright options with only declared dependencies available in packages/cli/src/__tests__/exports-map.spec.ts timed out on all three attempts of CLI E2E test (Linux x64 musl) on the release: v1.3.0 PR (#3079), and passed on the other platforms. This PR gives it a 15 s timeout, the same as the slow template test in register-template.spec.ts.

It is the first test in the file to run a full TypeScript program, so it also pays for TypeScript's warm-up. On the musl runner it normally stays under the 5 s default, but it has little margin:

Run Test Whole exports-map.spec.ts
main (6 recent runs) 1847 to 3432 ms 19.9 s
#3079 (3 attempts) 5206 to 5496 ms (timed out) 29.1 s

Every test in the file ran slower on the #3079 runner, not only this one, so the failure comes from runner speed rather than from the release changes.

🤖 Generated with Claude Code

The first full TypeScript check in exports-map.spec.ts takes up to about
3 s on the Alpine musl runner, and a slow runner pushes it past Vitest's
5 s default timeout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://test-exports-map-playwright-timeout-viteplus-dev.voidzero-docs.workers.dev (commit 9a10304)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://1535331f-viteplus-dev.voidzero-docs.workers.dev 9a10304 2026-10-17T06:59:10.870Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://3ad49366-viteplus-dev.voidzero-docs.workers.dev da0e613 2026-10-16T04:15:19.652Z Visit the dashboard ↗

@fengmk2
fengmk2 requested review from cpojer and wan9chi October 16, 2026 04:21
@fengmk2
fengmk2 merged commit 401ada6 into main Oct 17, 2026
48 checks passed
@fengmk2
fengmk2 deleted the test/exports-map-playwright-timeout branch October 17, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants